Skip to content

gh-121832: Revert test skip introduced by #122150. - #122340

Merged
freakboy3742 merged 1 commit into
python:mainfrom
freakboy3742:revert-test-skip
Jul 27, 2024
Merged

gh-121832: Revert test skip introduced by #122150.#122340
freakboy3742 merged 1 commit into
python:mainfrom
freakboy3742:revert-test-skip

Conversation

@freakboy3742

@freakboy3742freakboy3742 commented Jul 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

#122150 introduced a test skip to restore CI for iOS as a temporary measure. This PR reverts the skip.

Fixes#121832.

@freakboy3742freakboy3742 added skip news 3.13 bugs and security fixes OS-ios 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Jul 27, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jul 27, 2024
Closed
@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting core review labels Jul 27, 2024
@freakboy3742

freakboy3742 commented Jul 27, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot iOS

@bedevere-bot

bedevere-bot commented Jul 27, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit ed280f0 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
freakboy3742 merged commit 863a92f into python:mainJul 27, 2024
@miss-islington-app

miss-islington-appBot commented Jul 27, 2024

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@freakboy3742
freakboy3742 deleted the revert-test-skip branch July 27, 2024 02:24
@miss-islington-app

miss-islington-appBot commented Jul 27, 2024

Copy link
Copy Markdown

Sorry, @freakboy3742, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 863a92f2bc708b9e3dfa9828bb8155b8d371e09c 3.13

@freakboy3742
freakboy3742 restored the revert-test-skip branch July 27, 2024 02:24
@freakboy3742freakboy3742 added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Jul 27, 2024
@miss-islington-app

miss-islington-appBot commented Jul 27, 2024

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 27, 2024

Copy link
Copy Markdown

Sorry, @freakboy3742, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 863a92f2bc708b9e3dfa9828bb8155b8d371e09c 3.13

@freakboy3742
freakboy3742 deleted the revert-test-skip branch July 27, 2024 02:30
@bedevere-app

bedevere-appBot commented Jul 27, 2024

Copy link
Copy Markdown

GH-122342 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 27, 2024
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jul 27, 2024
@freakboy3742
[3.13]pythongh-121832: Revert test skip introduced bypythonGH-122150.…
f6e57db
… (pythonGH-122340)
Revert test skip introduced by pythonGH-122150.
(cherry picked from commit 863a92f)
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit that referenced this pull request Jul 27, 2024
@freakboy3742
[3.13]gh-121832: Revert test skip introduced byGH-122150. (GH-122340)…
7b35c50
… (#122342)
Revert test skip introduced by GH-122150.
(cherry picked from commit 863a92f)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deilyned-deilyned-deily approved these changes

Assignees

@freakboy3742freakboy3742

Labels

3.13bugs and security fixes3.14bugs and security fixesOS-iosskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test suite crashes when run single process --with-pydebug enabled

3 participants

@freakboy3742@bedevere-bot@ned-deily