Uh oh!
There was an error while loading. Please reload this page.
GH-73991: Rework pathlib.Path.rmtree() into delete() - #122368
Conversation
Rename `pathlib.Path.rmtree()` to `delete()`, and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcoming `move()` and `copy()` methods (which will also accept any type of file.)
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
left a comment
There was a problem hiding this comment.
Implementation looks fine, only one question
A
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
barneygale
commented
Jul 30, 2024
@nineteendo I'd welcome your review on this, if you have the time and inclination. No worries if not! Thanks in advance :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
We generally put the more primitive functions first.
barneygale
commented
Aug 7, 2024
Thank you very much for the reviews :) |
AA-Turner
commented
Aug 7, 2024
Sorry for my tardiness! Do let me know if there's anything else I can usefully review A |
barneygale
commented
Aug 7, 2024
Not tardy at all I don't think! :]
Since you're offering, the next PR on the critical path here is #122369. But there's a lot going on there, so feel free to give it a miss or ask me to explain it further / break it up / whatever. Thanks again! And feel free to assign me when you next need a review of something. |
…n#122368) Rename `pathlib.Path.rmtree()` to `delete()`, and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcoming `move()` and `copy()` methods (which will also accept any type of file.)
Rename
pathlib.Path.rmtree()todelete(), and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcomingmove()andcopy()methods (which will also accept any type of file.)📚 Documentation preview 📚: https://cpython-previews--122368.org.readthedocs.build/