Skip to content

GH-73991: Rework pathlib.Path.copytree() into copy() - #122369

Merged
barneygale merged 20 commits into
python:mainfrom
barneygale:merge-copy-copytree
Aug 11, 2024
Merged

GH-73991: Rework pathlib.Path.copytree() into copy()#122369
barneygale merged 20 commits into
python:mainfrom
barneygale:merge-copy-copytree

Conversation

@barneygale

@barneygalebarneygale commented Jul 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Rename pathlib.Path.copy() to _copy_file() (i.e. make it private.)

Rename pathlib.Path.copytree() to copy(), and add support for copying non-directories. This simplifies the interface for users, and nicely complements the upcoming move() and delete() methods (which will also accept any type of file.)

📚 Documentation preview 📚: https://cpython-previews--122369.org.readthedocs.build/

@barneygale
pythonGH-73991: Reworkpathlib.Path.copytree()intocopy().
b7ce838
Rename `pathlib.Path.copy()` to `_copy_file()` (i.e. make it private.)
Rename `pathlib.Path.copytree()` to `copy()`, and add support for copying
non-directories. This simplifies the interface for users, and nicely
complements the upcoming `move()` and `delete()` methods (which will also
accept any type of file.)
@bedevere-appbedevere-appBot mentioned this pull request Jul 27, 2024
Closed
@barneygale
barneygale marked this pull request as ready for review July 30, 2024 17:21
@barneygale

barneygale commented Jul 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Making the old copy() method private was a bit of a can of worms, as it made our usage of _winapi.CopyFile2 simpler, which in turn removed any need for UnsupportedOperation to be defined in _os.py rather than _abc.py.

@barneygalebarneygale mentioned this pull request Jul 31, 2024
Merged
@barneygale

barneygale commented Aug 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Hey @nineteendo, could you review this please, if you're up for it? Thanks in advance!

nineteendo
nineteendo reviewed Aug 4, 2024
View reviewed changes
Comment threadDoc/library/pathlib.rst Outdated
Comment threadLib/pathlib/_abc.py
Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
nineteendo
nineteendo reviewed Aug 4, 2024
View reviewed changes
Comment threadDoc/library/pathlib.rst Outdated
@barneygalebarneygale mentioned this pull request Aug 7, 2024
Merged
AA-Turner
AA-Turner reviewed Aug 7, 2024
View reviewed changes
Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
Comment threadLib/pathlib/__init__.py Outdated
Comment threadLib/pathlib/_abc.py
Comment threadLib/pathlib/_abc.py Outdated
Comment threadLib/pathlib/_abc.py
barneygaleand others added 2 commits August 7, 2024 16:11
@barneygale@AA-Turner
Apply suggestions from code review
3b6405b
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@barneygale
Address some review feedback
03f9b7f
AA-Turner
AA-Turner approved these changes Aug 11, 2024
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke!

A

@barneygale

barneygale commented Aug 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you for the review, very helpful!

@barneygale
barneygale merged commit a6644d4 into python:mainAug 11, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@barneygale@AA-Turner@blhsing
pythonGH-73991: Reworkpathlib.Path.copytree()intocopy()(pytho…
cde45a6
…n#122369)
Rename `pathlib.Path.copy()` to `_copy_file()` (i.e. make it private.)
Rename `pathlib.Path.copytree()` to `copy()`, and add support for copying
non-directories. This simplifies the interface for users, and nicely
complements the upcoming `move()` and `delete()` methods (which will also
accept any type of file.)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@opk12opk12 mentioned this pull request Oct 4, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes
+1 more reviewer
@nineteendonineteendonineteendo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barneygale@AA-Turner@nineteendo