Skip to content

gh-122858: Deprecate asyncio.iscoroutinefunction - #122875

Merged
kumaraditya303 merged 16 commits into
python:mainfrom
Wulian233:asyncio
Aug 11, 2024
Merged

gh-122858: Deprecate asyncio.iscoroutinefunction#122875
kumaraditya303 merged 16 commits into
python:mainfrom
Wulian233:asyncio

Conversation

@Wulian233

@Wulian233Wulian233 commented Aug 10, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Same inspect.iscoroutinefunction, we don't need two different functions to do the same thing.

@bedevere-appbedevere-appBot mentioned this pull request Aug 10, 2024
Closed
@Wulian233
Wulian233 marked this pull request as draft August 10, 2024 02:52
@Wulian233

Wulian233 commented Aug 10, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

After my many fix, maybe it is normal for the Docs workflow to fail because the deprecated function asyncio.iscoroutinefunctiondoes not have a corresponding document page introduction

But I don't know how to solve this problem. Delete whatnew/3.14.rst: func: iscoroutinefunctiondoes?

(Solved)

@Wulian233
Wulian233 marked this pull request as ready for review August 10, 2024 04:15
kumaraditya303
kumaraditya303 reviewed Aug 10, 2024
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
kumaraditya303
kumaraditya303 reviewed Aug 10, 2024
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
kumaraditya303
kumaraditya303 reviewed Aug 10, 2024
View reviewed changes
Comment threadLib/asyncio/unix_events.py Outdated
@cjw296
cjw296 removed their request for review August 10, 2024 09:31
kumaraditya303
kumaraditya303 reviewed Aug 10, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-08-10-10-21-44.gh-issue-122858.ZC1rJD.rst Outdated
kumaraditya303
kumaraditya303 reviewed Aug 10, 2024
View reviewed changes
Comment threadLib/unittest/mock.py Outdated
sobolevn
sobolevn reviewed Aug 11, 2024
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use at least one test that ensures that the function is deprecated (which does not ignore the warnings).

@kumaraditya303

kumaraditya303 commented Aug 11, 2024

Copy link
Copy Markdown
Contributor

I am taking over this now.

@kumaraditya303
kumaraditya303 enabled auto-merge (squash) August 11, 2024 16:15
@kumaraditya303
kumaraditya303 merged commit bc9d92c into python:mainAug 11, 2024
@Wulian233
Wulian233 deleted the asyncio branch August 11, 2024 23:16
@ZeroIntensityZeroIntensity mentioned this pull request Aug 19, 2024
Closed
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@Wulian233@kumaraditya303@blhsing
pythongh-122858: Deprecateasyncio.iscoroutinefunction(python#122875)
2e65db5
Deprecate `asyncio.iscoroutinefunction` in favor of `inspect.iscoroutinefunction`.
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
AdamWill pushed a commit to AdamWill/cached-property that referenced this pull request Nov 5, 2024
@encukou@AdamWill
Use iscoroutinefunction from inspect not asyncio
cb1f82b
Python 3.14 will deprecate asyncio.iscoroutinefunction:
python/cpython#122875
inspect.iscoroutinefunction exists since 3.5 and our baseline
is 3.8, so we can just use it unconditionally.
Using a wrapper with @asyncio.coroutine in __get__ wasn't
necessary (the future from asyncio.ensure_future is awaitable,
and the wrapper doesn't do anything asynchronous), so the
logic can be simplified to just call asyncio.ensure_future
(to schedule the task and store the result when it's
available).
@AdamWillAdamWill mentioned this pull request Nov 5, 2024
Open
layday added a commit to layday/aiohttp that referenced this pull request Mar 29, 2025
@layday
Replace asyncio.iscoroutinefunction with inspect.iscoroutinefunction
1efe72f
`asyncio.iscoroutinefunction` was deprecated in python/cpython#122875.
This was referenced Mar 29, 2025
Merged
Merged
Merged
@paultiqpaultiq mentioned this pull request Aug 13, 2025
Closed
@edgarrmondragonedgarrmondragon mentioned this pull request Oct 6, 2025
Merged
jenshnielsen added a commit to jenshnielsen/opentelemetry-python that referenced this pull request Oct 22, 2025
@jenshnielsen
Fix python 3.14 deprecation warning
a36e923
asyncio.iscoroutinefunction is a wrapper around inspect.iscoroutinefunction and has been deprecated in 3.14
See python/cpython#122875 for reference
@jenshnielsenjenshnielsen mentioned this pull request Nov 3, 2025
Closed
@jonathan343jonathan343 mentioned this pull request Nov 25, 2025
Merged
@servusdei2018servusdei2018 mentioned this pull request Dec 16, 2025
Open
@donbarbosdonbarbos mentioned this pull request Dec 26, 2025
Merged
@commonismcommonism mentioned this pull request Mar 8, 2026
Closed
@mertyuks3lmertyuks3l mentioned this pull request Mar 30, 2026
Open
3 tasks
@sobolevnsobolevn mentioned this pull request May 9, 2026
Closed
@HanGhoulHanGhoul mentioned this pull request Jul 15, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wulian233@kumaraditya303@sobolevn