Uh oh!
There was an error while loading. Please reload this page.
Add asyncio 3.14 deprecations - #15176
Conversation
This comment has been minimized.
This comment has been minimized.
donbarbos
left a comment
There was a problem hiding this comment.
Thank you, just suggestion about messages.
PR: python/cpython#122875
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
max-muoto
commented
Dec 26, 2025
Good catch - would be best to follow the runtime messages here, will update. |
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
left a comment
There was a problem hiding this comment.
Could you also move the tests for the inspect functions to a new file check_inspect.py?
max-muoto
commented
Dec 27, 2025
Will do. |
max-muoto
commented
Dec 27, 2025
Done: 300644c |
Diff from mypy_primer, showing the effect of this PR on open source code: aiohttp (https://github.com/aio-libs/aiohttp)
+ aiohttp/web_urldispatcher.py:159:44: error: overload def [_P, _T] (func: def (*_P.args, **_P.kwargs) -> typing.Awaitable[_T`-2]) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, _T`-2]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead. [deprecated]+ aiohttp/web_urldispatcher.py:159:44: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-deprecated for more info [deprecated]+ aiohttp/web_urldispatcher.py:167:44: error: overload def [_P, _T] (func: def (*_P.args, **_P.kwargs) -> typing.Awaitable[_T`-2]) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, _T`-2]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead. [deprecated]+ aiohttp/worker.py:68:44: error: overload def [_P] (func: def (*_P.args, **_P.kwargs) -> builtins.object) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, Any]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead. [deprecated] |
Uh oh!
There was an error while loading. Please reload this page.
This PR adds the
asyncio.iscoroutinefunctiondeprecations from #14289 with the only core change being that we only deprecate them for >= 3.11 due to @srittau's feedback here: #14074 (comment)