Uh oh!
There was an error while loading. Please reload this page.
gh-124487: Require at least Windows 10 SDK and for install - #124672
Merged
Conversation
zooba
commented
Sep 27, 2024
MemberAuthor
#124676 is an alternative fix that might be considered for 3.13 instead of this one. |
Wulian233
left a comment
Contributor
There was a problem hiding this comment.
Is the minimum installation requirement for PR now Win10? If yes, I think the FailureOldOS information needs to be changed as well
https://github.com/search?q=repo%3Apython%2Fcpython%20FailureOldOS&type=code
At least Windows 8.1 or Windows Server 2012 are required to install
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wulian <1055917385@qq.com>
zooba
commented
Sep 30, 2024
MemberAuthor
Thanks for the review! Good catches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.