Skip to content

gh-109413: Add more type hints to libregrtest - #126352

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-109413
Nov 4, 2024
Merged

gh-109413: Add more type hints to libregrtest#126352
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-109413

Conversation

@sobolevn

@sobolevnsobolevn commented Nov 3, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

While working on #126237 I've noticed that there are quite a lot of simple and uncontroversial type hints that I can add to libregrtest.

I also bumped mypy to the recent version (it is the same as 1.12, but faster).

@bedevere-appbedevere-appBot mentioned this pull request Nov 3, 2024
Closed
vstinner
vstinner approved these changes Nov 4, 2024
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
sobolevn merged commit bfc1d25 into python:mainNov 4, 2024
@sobolevn

sobolevn commented Nov 4, 2024

Copy link
Copy Markdown
MemberAuthor

Thank you! I think that we backport such changes (based on experience of #109413), so I will add labels!

@sobolevnsobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 4, 2024
@miss-islington-app

miss-islington-appBot commented Nov 4, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 4, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 4, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bfc1d2504c183a9464e65c290e48516d176ea41f 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 4, 2024
@sobolevn@miss-islington
pythongh-109413: Add more type hints tolibregrtest(pythonGH-126352)
0f8ab5c
(cherry picked from commit bfc1d25)
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Nov 4, 2024

Copy link
Copy Markdown

GH-126388 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 4, 2024
@sobolevn

sobolevn commented Nov 4, 2024

Copy link
Copy Markdown
MemberAuthor

I will try to create a manual backport to 3.12, but it is not easy: #125597

@AlexWaygood

AlexWaygood commented Nov 4, 2024

Copy link
Copy Markdown
Member

Thanks! If you're interested in working in more improvements here, the mypy config we use for libregrtest is extremely lenient at the moment; ideally we'd make it stricter. In particular, we still have strict_optional = false for several submodules of libregrtest 😱 https://github.com/python/cpython/blob/main/Lib/test/libregrtest/mypy.ini

I will try to create a manual backport to 3.12, but it is not easy: #125597

I wouldn't worry about it too much if it's hard. I wouldn't say that these changes are important to backport in and of themselves. The main reason to backport them is to reduce the risk of merge conflicts when backporting future bugfixes (which are important to backport) to libregrtest. If we run into such merge conflicts in the future, I think it shouldn't be too hard to just remove the type hints from certain functions in order to solve the conflicts with the 3.12 branch.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 4, 2024
@sobolevn
[3.12]pythongh-109413: Add more type hints tolibregrtest(pythonG…
a450024
…H-126352)
(cherry picked from commit bfc1d25)
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 4, 2024
@sobolevn
[3.12]pythongh-109413: Add more type hints tolibregrtest(pythonG…
9a111d5
…H-126352)
(cherry picked from commit bfc1d25)
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Nov 4, 2024

Copy link
Copy Markdown

GH-126389 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 4, 2024
@sobolevn

sobolevn commented Nov 4, 2024

Copy link
Copy Markdown
MemberAuthor

Yes, I am working on some further fixes :)
But before I fix fixes here, I have to fix fixes in mypy first 😆
python/mypy#18103

@sobolevnsobolevn mentioned this pull request Nov 4, 2024
Merged
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@sobolevn@picnixz
pythongh-109413: Add more type hints tolibregrtest(python#126352)
93f9c6f
sobolevn added a commit that referenced this pull request Jan 8, 2025
@miss-islington@sobolevn
[3.13]gh-109413: Add more type hints tolibregrtest(GH-126352) (#…
32012ed
…126388)
gh-109413: Add more type hints to `libregrtest` (GH-126352)
(cherry picked from commit bfc1d25)
Co-authored-by: sobolevn <mail@sobolevn.me>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@sobolevn@ebonnal
pythongh-109413: Add more type hints tolibregrtest(python#126352)
affbdb2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees

@sobolevnsobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@AlexWaygood@vstinner