Skip to content

Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14" - #126370

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:rm-sqlite3-pending
Nov 3, 2024
Merged

Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14"#126370
hugovk merged 1 commit into
python:mainfrom
hugovk:rm-sqlite3-pending

Conversation

@hugovk

@hugovkhugovk commented Nov 3, 2024

Copy link
Copy Markdown
Member

This was deprecated in 3.12 (#94276) but never planned to be removed in 3.14. It was added to the "Pending removal in Python 3.14" list by mistake, probably assuming it would be removed in +2 releases.

https://docs.python.org/3.13/library/sqlite3.html#default-adapters-and-converters-deprecated is correct: only says deprecated in 3.12.

See also https://discuss.python.org/t/deprecate-default-built-in-sqlite3-converters-and-adapters/15781.


📚 Documentation preview 📚: https://cpython-previews--126370.org.readthedocs.build/

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 3, 2024
@hugovkhugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip issue docs Documentation in the Doc dir awaiting core review skip news and removed docs Documentation in the Doc dir awaiting core review skip news labels Nov 3, 2024
@hugovkhugovk changed the title Docs: remove sqlite3 deprecation with no pending removal dateDocs: Delist sqlite3 deprecation from "Pending removal in 3.14"Nov 3, 2024

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk enabled auto-merge (squash) November 3, 2024 21:15
@hugovk
hugovk merged commit 9441993 into python:mainNov 3, 2024
@hugovk
hugovk deleted the rm-sqlite3-pending branch November 3, 2024 21:22
@miss-islington-app

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2024
…onGH-126370)
(cherry picked from commit 9441993)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2024
…onGH-126370)
(cherry picked from commit 9441993)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

Copy link
Copy Markdown

GH-126372 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 3, 2024
@bedevere-app

Copy link
Copy Markdown

GH-126373 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 3, 2024
hugovk added a commit that referenced this pull request Nov 3, 2024
GH-126370) (#126372)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Nov 3, 2024
GH-126370) (#126373)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Wulian233

Copy link
Copy Markdown
Contributor

Should we add it to pending remove in future.rst?

@erlend-aasland

Copy link
Copy Markdown
Contributor

Should we add it to pending remove in future.rst?

No; it is not pending removal at all.

@gpsheadgpshead changed the title Docs: Delist sqlite3 deprecation from "Pending removal in 3.14"Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14"Nov 10, 2024
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip newstopic-sqlite3

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@Wulian233@erlend-aasland