Skip to content

gh-90016: Deprecate default sqlite3 adapters and converters - #94276

Merged
erlend-aasland merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-deprecate-adapters
Jul 20, 2022
Merged

gh-90016: Deprecate default sqlite3 adapters and converters#94276
erlend-aasland merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-deprecate-adapters

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 25, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Closesgh-90016

@erlend-aaslanderlend-aasland mentioned this pull request Jun 25, 2022
Closed
@erlend-aasland

erlend-aasland commented Jun 25, 2022

Copy link
Copy Markdown
ContributorAuthor

cc. @iafisher: would you mind reviewing this?

iafisher
iafisher reviewed Jun 25, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadLib/sqlite3/dbapi2.py
erlend-aasland
erlend-aasland commented Jun 26, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
Erlend Egeberg Aaslandand others added 2 commits June 27, 2022 18:00
CAM-Gerlach
CAM-Gerlach reviewed Jun 29, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.

Comment threadDoc/library/sqlite3.rst
Comment threadDoc/whatsnew/3.12.rst Outdated
Comment threadMisc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Outdated
Comment threadLib/sqlite3/dbapi2.py Outdated
Comment threadDoc/library/sqlite3.rst
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst
Comment threadDoc/library/sqlite3.rst Outdated
AlexWaygood
AlexWaygood reviewed Jul 1, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, +1 to most of Cam's thoughts

@erlend-aasland

erlend-aasland commented Jul 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Reviews addressed in d3dd3b4

CAM-Gerlach
CAM-Gerlach approved these changes Jul 2, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland ! Just two minor fixes, both my mistake.

Comment threadMisc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Outdated
Comment threadDoc/whatsnew/3.12.rst Outdated
Erlend Egeberg Aaslandand others added 2 commits July 2, 2022 08:34
Erlend Egeberg Aasland@CAM-Gerlach
Update Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB…
df4dc31
…409s.rst
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Erlend Egeberg Aasland@CAM-Gerlach
Update Doc/whatsnew/3.12.rst
ffdf631
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland

erlend-aasland commented Jul 3, 2022

Copy link
Copy Markdown
ContributorAuthor

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

@serhiy-storchaka and @malemburg, would you two mind reviewing this?

@felixxm

felixxm commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

Yes, it works for us 👍 Thanks for letting me know 🎁 . I prepared PR with missing adapters/converters for Django, see django/django#15815.

felixxm
felixxm approved these changes Jul 4, 2022
View reviewed changes

@felixxmfelixxm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland Thanks 👍

Comment threadLib/sqlite3/dbapi2.py Outdated
@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
ContributorAuthor

I'll resolve the conflicts and land this PR later tonight.

@erlend-aasland
erlend-aasland merged commit 6dadf6c into python:mainJul 20, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-deprecate-adapters branch July 20, 2022 19:38
@hugovkhugovk mentioned this pull request Nov 3, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka
@malemburgmalemburgAwaiting requested review from malemburg
+2 more reviewers
@iafisheriafisheriafisher left review comments
@felixxmfelixxmfelixxm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate default converters in sqlite3

6 participants

@erlend-aasland@felixxm@iafisher@CAM-Gerlach@AlexWaygood@bedevere-bot