gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged

[graingert]

• Issue: configure warnings as errors in the test suite #128770

[graingert]

@hugovk can I get a run on the buildbots for this PR?

[hugovk]

Certainly!

Let's check if you can do it yourself: either apply one of the test-with-buildbots or test-with-refleak-buildbots labels, or add a comment like ! buildbot optional-regex (but no space between exclamation mark and buildbot) to run a subset.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @graingert for commit c06c3db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @graingert for commit 7123093 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[graingert]

@hugovk do you know where I can see the status?

[hugovk]

You can click the "Details" links in the status checks:

Some of those failing ones were already failing for previous builds, so aren't necessarily caused by this PR.

[graingert]

You can click the "Details" links in the status checks:

Some of those failing ones were already failing for previous builds, so aren't necessarily caused by this PR.

Ah those hadn't shown up yet

[hugovk]

The warnings have been fixed in other PRs in main, and this PR is back to turning future warnings into errors. If there are no objections, I'll merge this later today.

[miss-islington-app]

Thanks @graingert for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington-app]

Sorry, @graingert and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a00c9a4d2ce9d373b13f8f0a2265a65f4523293 3.13

[miss-islington-app]

Sorry, @graingert and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a00c9a4d2ce9d373b13f8f0a2265a65f4523293 3.12

[bedevere-app]

GH-131802 is a backport of this pull request to the 3.13 branch.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO 3.x (tier-2) has failed when building commit 8a00c9a.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/336/builds/6580) and take a look at the build logs.
4. Check if the failure is related to this commit (8a00c9a) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/336/builds/6580

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_innerself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
interp = interpreters.create()
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in createid= _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_innerself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
interp = interpreters.create()
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in createid= _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

[graingert]

the failure is related to this commit, however the code in this PR is working as intended. This has uncovered an issue in subinterpreters:

test_create_many_threaded (test.test_interpreters.test_stress.StressTests.test_create_many_threaded) ... Warning--Uncaughtthreadexception: InterpreterErrorExceptioninthreadThread-166 (task):
RuntimeError: FailedtoimportencodingsmoduleDuringhandlingoftheaboveexception, anotherexceptionoccurred:
interpreters.InterpreterError: sub-interpretercreationfailedDuringhandlingoftheaboveexception, anotherexceptionoccurred:
Traceback (mostrecentcalllast):
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line1054, in_bootstrap_innerself.run()
~~~~~~~~^^File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line996, inrunself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line30, intaskinterp=interpreters.create()
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line76, increateid=_interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpretercreationfailed

[ZeroIntensity]

That's a known failure, don't worry about it.

[graingert]

Ah you're right it's not a Warning that got raised as an Exception! I panicked like the message said not to

[bedevere-app]

GH-131824 is a backport of this pull request to the 3.12 branch.