Skip to content

GH-91079: Fix stack overflow on AMD LTO linux - #130369

Closed
markshannon wants to merge 2 commits into
python:mainfrom
faster-cpython:fix-lto-stack
Closed

GH-91079: Fix stack overflow on AMD LTO linux#130369
markshannon wants to merge 2 commits into
python:mainfrom
faster-cpython:fix-lto-stack

Conversation

@markshannon

@markshannonmarkshannon commented Feb 20, 2025

Copy link
Copy Markdown
Member

In #130007 we increased the default stack size from an estimated 4MB to 5MB.
This PR resets it to 3M.

This is a temporary fix until #130396 is implemented

@markshannon

Copy link
Copy Markdown
MemberAuthor

!buildbot fedora lto

@bedevere-bot

Copy link
Copy Markdown

The regex 'fedora lto' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@markshannon

Copy link
Copy Markdown
MemberAuthor

!buildbot "AMD64 Fedora Stable LTO"

@bedevere-bot

Copy link
Copy Markdown

The regex '"AMD64 Fedora Stable LTO"' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@markshannon

Copy link
Copy Markdown
MemberAuthor

!buildbot LTO

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit efef9bd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130369%2Fmerge

The command will test the builders whose names match following regular expression: LTO

The builders matched are:

  • PPC64LE CentOS9 LTO PR
  • AMD64 Fedora Rawhide LTO PR
  • s390x RHEL8 LTO + PGO PR
  • aarch64 Fedora Rawhide LTO PR
  • s390x RHEL9 LTO PR
  • PPC64LE CentOS9 LTO + PGO PR
  • AMD64 Fedora Stable LTO PR
  • aarch64 CentOS9 LTO PR
  • aarch64 Fedora Stable LTO PR
  • AMD64 Fedora Rawhide LTO + PGO PR
  • s390x RHEL8 LTO PR
  • AMD64 CentOS9 LTO + PGO PR
  • PPC64LE Fedora Stable LTO PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • AMD64 RHEL8 LTO PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • AMD64 RHEL8 LTO + PGO PR
  • PPC64LE RHEL8 LTO + PGO PR
  • s390x RHEL9 LTO + PGO PR
  • PPC64LE RHEL8 LTO PR
  • AMD64 CentOS9 LTO PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • PPC64LE Fedora Rawhide LTO PR
  • aarch64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Stable LTO + PGO PR
  • aarch64 RHEL8 LTO + PGO PR
  • aarch64 RHEL8 LTO PR
  • aarch64 CentOS9 LTO + PGO PR

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@markshannon

Copy link
Copy Markdown
MemberAuthor

!buildbot Fedora.*LTO

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2aa6878 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130369%2Fmerge

The command will test the builders whose names match following regular expression: Fedora.*LTO

The builders matched are:

  • aarch64 Fedora Stable LTO + PGO PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • AMD64 Fedora Rawhide LTO PR
  • AMD64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Rawhide LTO PR
  • AMD64 Fedora Stable LTO PR
  • PPC64LE Fedora Stable LTO PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Stable LTO PR
  • PPC64LE Fedora Rawhide LTO PR

@markshannon

Copy link
Copy Markdown
MemberAuthor

#130398 fixes the same issue and a lot more.

@markshannon
markshannon deleted the fix-lto-stack branch February 27, 2025 11:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@bedevere-bot@brandtbucher