Uh oh!
There was an error while loading. Please reload this page.
GH-130396: Use computed stack limits on linux - #130398
Conversation
ec4cc83 to
6b48afeComparemarkshannon
commented
Feb 21, 2025
!buildbot .* |
bedevere-bot
commented
Feb 21, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 12f9ce7 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
brandtbucher
left a comment
There was a problem hiding this comment.
I'm definitely not an expert in this particular area, but the changes seem reasonable (provided the buildbots are happy).
Uh oh!
There was an error while loading. Please reload this page.
| * no two calls to check recursion depth are more than this far | ||
| * apart. In practice, that means it must be larger than the C | ||
| * stack consumption of PyEval_EvalDefault */ |
There was a problem hiding this comment.
This seems sort of fragile? What if there's a ton of unrelated C calls (maybe from a C extension) between two interpreter entries? Does that cause this to be incorrect?
There was a problem hiding this comment.
Any C code that can recurse needs to do checks.
We already do that in plenty of places, like the parser, compiler, json encoding, etc.
C extensions should do it too.
Uh oh!
There was an error while loading. Please reload this page.
markshannon
commented
Feb 22, 2025
Ignoring prior failures and timesouts, the buildbot fialures are webassembly stack overflows and a couple of odd AIX failures. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markshannon
commented
Feb 22, 2025
!buildbot was[i|m] |
bedevere-bot
commented
Feb 22, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f6002e5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 22, 2025
!buildbot AIX |
bedevere-bot
commented
Feb 22, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f6002e5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 24, 2025
!buildbot iOS |
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 24, 2025
Compilation failures on both AIX buildbots, but unrelated to this PR. |
markshannon
commented
Feb 24, 2025
!buildbot wasm |
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 24, 2025
!buildbot iOS |
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit b3ccffc 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 24, 2025
!buildbot iOS |
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 24, 2025
!buildbot wasm |
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
commented
Feb 24, 2025
!buildbot wasm |
bedevere-bot
commented
Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
bedevere-bot
commented
Feb 25, 2025
|
bedevere-bot
commented
Feb 25, 2025
|
Yhg1s
commented
Mar 26, 2025
FYI, this introduced a new warning in MSVC: so I don't think the attempts to hide the taking of the address of the stack variable work on MSVC. |
Technically, not just linux, but any platform with
pthread_getattr_np.