Uh oh!
There was an error while loading. Please reload this page.
gh-130737: Fix multiprocessing test_notify() - #130797
Conversation
Replace hardcoded delay (100 ms) with a loop awaiting until a condition is true: replace assertReturnsIfImplemented() with assertReachesEventually(). Use sleeping_retry() in assertReachesEventually() to tolerate slow buildbots and raise an exception on timeout (30 seconds).
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Replace hardcoded delay (100 ms) with a loop awaiting until a condition is true: replace assertReturnsIfImplemented() with assertReachesEventually(). Use sleeping_retry() in assertReachesEventually() to tolerate slow buildbots and raise an exception on timeout (30 seconds). (cherry picked from commit 8a64a62) Co-authored-by: Victor Stinner <vstinner@python.org>
GH-130802 is a backport of this pull request to the 3.13 branch. |
Replace hardcoded delay (100 ms) with a loop awaiting until a condition is true: replace assertReturnsIfImplemented() with assertReachesEventually(). Use sleeping_retry() in assertReachesEventually() to tolerate slow buildbots and raise an exception on timeout (30 seconds). (cherry picked from commit 8a64a62) Co-authored-by: Victor Stinner <vstinner@python.org>
GH-130803 is a backport of this pull request to the 3.12 branch. |
vstinner
commented
Mar 3, 2025
Merged, thanks for the review @gpshead. |
) gh-130737: Fix multiprocessing test_notify() (GH-130797) Replace hardcoded delay (100 ms) with a loop awaiting until a condition is true: replace assertReturnsIfImplemented() with assertReachesEventually(). Use sleeping_retry() in assertReachesEventually() to tolerate slow buildbots and raise an exception on timeout (30 seconds). (cherry picked from commit 8a64a62) Co-authored-by: Victor Stinner <vstinner@python.org>
) gh-130737: Fix multiprocessing test_notify() (GH-130797) Replace hardcoded delay (100 ms) with a loop awaiting until a condition is true: replace assertReturnsIfImplemented() with assertReachesEventually(). Use sleeping_retry() in assertReachesEventually() to tolerate slow buildbots and raise an exception on timeout (30 seconds). (cherry picked from commit 8a64a62) Co-authored-by: Victor Stinner <vstinner@python.org>
bedevere-bot
commented
Mar 3, 2025
|
bedevere-bot
commented
Mar 3, 2025
|
bedevere-bot
commented
Mar 4, 2025
|
bedevere-bot
commented
Mar 4, 2025
|
bedevere-bot
commented
Mar 4, 2025
|
colesbury
commented
Mar 6, 2025
It looks like the change to |
colesbury
commented
Mar 6, 2025
#130933 should fix the I think I understand why the change to |
Replace hardcoded delay (100 ms) with a loop awaiting until a condition is true: replace assertReturnsIfImplemented() with assertReachesEventually().
Use sleeping_retry() in assertReachesEventually() to tolerate slow buildbots and raise an exception on timeout (30 seconds).
test_notifymultiprocessing test is flaky #130737