Uh oh!
There was an error while loading. Please reload this page.
gh-110206: Fix multiprocessing test_notify_all - #130933
Merged
Merged
Conversation
The test could deadlock trying join on the worker processes due to a combination of behaviors: * The use of `assertReachesEventually` did not ensure that workers actually woken.release() because the SyncManager's Semaphore does not implement get_value. * This mean that the test could finish and the variable "sleeping" would got out of scope and be collected. This unregisters the proxy leading to failures in the worker or possibly the manager. * The subsequent call to `p.join()` during cleanUp therefore never finished. This takes two approaches to fix this: 1) Use woken.acquire() to ensure that the workers actually finish calling woken.release() 2) Wait until the workers finish during the test, while cond, sleeping, and woken are still valid.
bedevere-bot
commented
Mar 6, 2025
🤖 New build scheduled with the buildbot fleet by @colesbury for commit c06d0f1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130933%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
gpshead
reviewed
Mar 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Mar 7, 2025
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 19c049d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130933%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
colesbury
commented
Mar 7, 2025
ContributorAuthor
nogil refleak buildbot failures will be fixed by #130901 |
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2025
The test could deadlock trying join on the worker processes due to a combination of behaviors: * The use of `assertReachesEventually` did not ensure that workers actually woken.release() because the SyncManager's Semaphore does not implement get_value. * This mean that the test could finish and the variable "sleeping" would got out of scope and be collected. This unregisters the proxy leading to failures in the worker or possibly the manager. * The subsequent call to `p.join()` during cleanUp therefore never finished. This takes two approaches to fix this: 1) Use woken.acquire() to ensure that the workers actually finish calling woken.release() 2) At the end of the test, wait until the workers are finished, while `cond`, `sleeping`, and `woken` are still valid. (cherry picked from commit c476410) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-130950 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2025
The test could deadlock trying join on the worker processes due to a combination of behaviors: * The use of `assertReachesEventually` did not ensure that workers actually woken.release() because the SyncManager's Semaphore does not implement get_value. * This mean that the test could finish and the variable "sleeping" would got out of scope and be collected. This unregisters the proxy leading to failures in the worker or possibly the manager. * The subsequent call to `p.join()` during cleanUp therefore never finished. This takes two approaches to fix this: 1) Use woken.acquire() to ensure that the workers actually finish calling woken.release() 2) At the end of the test, wait until the workers are finished, while `cond`, `sleeping`, and `woken` are still valid. (cherry picked from commit c476410) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-130951 is a backport of this pull request to the 3.12 branch. |
colesbury added a commit
to colesbury/cpython
that referenced
this pull request
Mar 7, 2025
The test could deadlock trying join on the worker processes. Apply the same technique as pythongh-130933. Join the process before the test ends in `test_notify` as well.
colesbury added a commit
that referenced
this pull request
Mar 7, 2025
…30951) The test could deadlock trying join on the worker processes due to a combination of behaviors: * The use of `assertReachesEventually` did not ensure that workers actually woken.release() because the SyncManager's Semaphore does not implement get_value. * This mean that the test could finish and the variable "sleeping" would got out of scope and be collected. This unregisters the proxy leading to failures in the worker or possibly the manager. * The subsequent call to `p.join()` during cleanUp therefore never finished. This takes two approaches to fix this: 1) Use woken.acquire() to ensure that the workers actually finish calling woken.release() 2) At the end of the test, wait until the workers are finished, while `cond`, `sleeping`, and `woken` are still valid. (cherry picked from commit c476410) Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit
that referenced
this pull request
Mar 7, 2025
…30950) The test could deadlock trying join on the worker processes due to a combination of behaviors: * The use of `assertReachesEventually` did not ensure that workers actually woken.release() because the SyncManager's Semaphore does not implement get_value. * This mean that the test could finish and the variable "sleeping" would got out of scope and be collected. This unregisters the proxy leading to failures in the worker or possibly the manager. * The subsequent call to `p.join()` during cleanUp therefore never finished. This takes two approaches to fix this: 1) Use woken.acquire() to ensure that the workers actually finish calling woken.release() 2) At the end of the test, wait until the workers are finished, while `cond`, `sleeping`, and `woken` are still valid. (cherry picked from commit c476410) Co-authored-by: Sam Gross <colesbury@gmail.com>
bedevere-bot
commented
Mar 7, 2025
|
colesbury added a commit
that referenced
this pull request
Mar 8, 2025
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2025
The test could deadlock trying join on the worker processes. Apply the same technique as pythongh-130933. Join the process before the test ends in `test_notify` as well. (cherry picked from commit edd1eca) Co-authored-by: Sam Gross <colesbury@gmail.com>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2025
The test could deadlock trying join on the worker processes. Apply the same technique as pythongh-130933. Join the process before the test ends in `test_notify` as well. (cherry picked from commit edd1eca) Co-authored-by: Sam Gross <colesbury@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test could deadlock trying join on the worker processes due to a combination of behaviors:
The use of
assertReachesEventuallydid not ensure that workers actually calledwoken.release()because the SyncManager's Semaphore does not implement get_value.This mean that the test could finish and the variable "sleeping" would got out of scope and be collected. This unregisters the proxy leading to failures in the worker or possibly the manager.
The subsequent call to
p.join()during cleanUp therefore never finished.This takes two approaches to fix this:
Use woken.acquire() to ensure that the workers actually finish calling
woken.release().Wait until the workers finish during the test, while cond, sleeping,
and woken are still valid.