Uh oh!
There was an error while loading. Please reload this page.
gh-128563: Add correction note to tail call in whats new - #130908
Merged
Conversation
Fidget-Spinner
commented
Mar 6, 2025
MemberAuthor
Merging ASAP so we don't further unintentionally mislead anyone. |
bedevere-bot
commented
Mar 6, 2025
|
bedevere-bot
commented
Mar 6, 2025
|
Fidget-Spinner
commented
Mar 6, 2025
MemberAuthor
@nelhage fyi i gave you credit for finding this as well in the whats new, please check it out :)! |
mdboom
reviewed
Mar 6, 2025
| .. attention:: | ||
| This section previously reported a 9-15% geomean speedup. This number has since been |
Contributor
There was a problem hiding this comment.
Can we say "geometric mean" here? I think geomean is too jargonny.
MemberAuthor
There was a problem hiding this comment.
🤦 thanks, but I automerged too quickly.
mdboom
reviewed
Mar 6, 2025
| cautiously revised down to 3-5%. While we expect performance results to be better | ||
| than what we report, our estimates are more conservative due to a | ||
| `compiler bug <https://github.com/llvm/llvm-project/issues/106846>`_ found in | ||
| Clang/LLVM 19. We were unaware of this bug, and it artifically boosted |
Contributor
There was a problem hiding this comment.
Instead of saying "artificially boosted our numbers" (which seems to imply it magically made tail calling even better), maybe say "which negatively impacted the performance of the traditional non-tail calling interpreter loop"
MemberAuthor
There was a problem hiding this comment.
Yeah Stefan Marr pointed out that the artificially boosting comment makes no sense too. So I addressed that here #130911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nelhage
📚 Documentation preview 📚: https://cpython-previews--130908.org.readthedocs.build/