Skip to content

gh-128563: Clarify wording in Whats new for Tail call - #130911

Merged
Fidget-Spinner merged 1 commit into
python:mainfrom
Fidget-Spinner:tailcall-wording
Mar 6, 2025
Merged

gh-128563: Clarify wording in Whats new for Tail call#130911
Fidget-Spinner merged 1 commit into
python:mainfrom
Fidget-Spinner:tailcall-wording

Conversation

@Fidget-Spinner

@Fidget-SpinnerFidget-Spinner commented Mar 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Pointed out by @smarr that the old wording was confusing.

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting core review labels Mar 6, 2025
@bedevere-appbedevere-appBot mentioned this pull request Mar 6, 2025
Closed
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) March 6, 2025 13:32
@Fidget-Spinner
Fidget-Spinner merged commit 9c69150 into python:mainMar 6, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsMar 6, 2025
@Fidget-SpinnerFidget-Spinner mentioned this pull request Mar 6, 2025
Merged
@bedevere-bot

bedevere-bot commented Mar 6, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 Refleaks 3.x (tier-3) has failed when building commit 9c69150.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1589/builds/1066) and take a look at the build logs.
  4. Check if the failure is related to this commit (9c69150) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1589/builds/1066

Failed tests:

  • test.test_multiprocessing_spawn.test_manager

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 313, in _bootstrapself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 1625, in f
woken.release()
~~~~~~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 1067, in releasereturnself._callmethod('release')
~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 848, in _callmethodraise convert_to_error(kind, result)
multiprocessing.managers.RemoteError: ---------------------------------------------------------------------------
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 264, in serve_clientself.id_to_local_proxy_obj[ident]
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^KeyError: '3ff875974e0'
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 313, in _bootstrapself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 1625, in f
woken.release()
~~~~~~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 1067, in releasereturnself._callmethod('release')
~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 848, in _callmethodraise convert_to_error(kind, result)
multiprocessing.managers.RemoteError: ---------------------------------------------------------------------------
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 264, in serve_clientself.id_to_local_proxy_obj[ident]
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^KeyError: '3ff8b617620'
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 313, in _bootstrapself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 1625, in f
woken.release()
~~~~~~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 1067, in releasereturnself._callmethod('release')
~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 848, in _callmethodraise convert_to_error(kind, result)
multiprocessing.managers.RemoteError: ---------------------------------------------------------------------------
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 264, in serve_clientself.id_to_local_proxy_obj[ident]
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^KeyError: '3ff87635aa0'
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 313, in _bootstrapself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 1625, in f
woken.release()
~~~~~~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 1067, in releasereturnself._callmethod('release')
~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 848, in _callmethodraise convert_to_error(kind, result)
multiprocessing.managers.RemoteError: ---------------------------------------------------------------------------
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 264, in serve_clientself.id_to_local_proxy_obj[ident]
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^KeyError: '3ff8e6b5aa0'
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 313, in _bootstrapself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 1625, in f
woken.release()
~~~~~~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 1067, in releasereturnself._callmethod('release')
~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 848, in _callmethodraise convert_to_error(kind, result)
multiprocessing.managers.RemoteError: ---------------------------------------------------------------------------
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 264, in serve_clientself.id_to_local_proxy_obj[ident]
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^KeyError: '3ff76cb5aa0'
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 266, in serve_clientraise ke
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 260, in serve_client
obj, exposed, gettypeid = id_to_obj[ident]
~~~~~~~~~^^^^^^^KeyError: '3ff8e6b5aa0'
---------------------------------------------------------------------------
Timeout (0:45:00)!
Thread 0x000003ff99073740 (most recent call first):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 28 in poll
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 44 in wait
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 149 in join
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 623 in _callCleanup
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 697 in doCleanups
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 664 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 716 in __call__
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 122 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 84 in __call__
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 122 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 84 in __call__
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/runner.py", line 259 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 84 in _run_suite
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 42 in run_unittest
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 162 in test_func
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/refleak.py", line 132 in runtest_refleak
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 114 in regrtest_runner
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 165 in _load_run_test
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 210 in _runtest_env_changed_exc
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 319 in _runtest
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 348 in run_single_test
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/worker.py", line 92 in worker_process
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/worker.py", line 127 in main
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/worker.py", line 131 in <module>
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/runpy.py", line 88 in _run_code
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/runpy.py", line 198 in _run_module_as_main
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 266, in serve_clientraise ke
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 260, in serve_client
obj, exposed, gettypeid = id_to_obj[ident]
~~~~~~~~~^^^^^^^KeyError: '3ff76cb5aa0'
---------------------------------------------------------------------------
Timeout (0:45:00)!
Thread 0x000003ff9c173740 (most recent call first):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 28 in poll
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 44 in wait
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 149 in join
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 623 in _callCleanup
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 697 in doCleanups
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 664 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/case.py", line 716 in __call__
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 122 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 84 in __call__
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 122 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/suite.py", line 84 in __call__
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/unittest/runner.py", line 259 in run
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 84 in _run_suite
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 42 in run_unittest
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 162 in test_func
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/refleak.py", line 132 in runtest_refleak
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 114 in regrtest_runner
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 165 in _load_run_test
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 210 in _runtest_env_changed_exc
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 319 in _runtest
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/single.py", line 348 in run_single_test
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/worker.py", line 92 in worker_process
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/worker.py", line 127 in main
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/libregrtest/worker.py", line 131 in <module>
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/runpy.py", line 88 in _run_code
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/runpy.py", line 198 in _run_module_as_main
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 266, in serve_clientraise ke
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 260, in serve_client
obj, exposed, gettypeid = id_to_obj[ident]
~~~~~~~~~^^^^^^^KeyError: '3ff875974e0'
---------------------------------------------------------------------------
k
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 266, in serve_clientraise ke
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 260, in serve_client
obj, exposed, gettypeid = id_to_obj[ident]
~~~~~~~~~^^^^^^^KeyError: '3ff8b617620'
---------------------------------------------------------------------------
k
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 266, in serve_clientraise ke
File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/managers.py", line 260, in serve_client
obj, exposed, gettypeid = id_to_obj[ident]
~~~~~~~~~^^^^^^^KeyError: '3ff87635aa0'
---------------------------------------------------------------------------
k

hauntsaninja
hauntsaninja reviewed Mar 7, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst
@@ -301,11 +301,11 @@ For further information on how to build Python, see
cautiously revised down to 3-5%. While we expect performance results to be better

@hauntsaninjahauntsaninjaMar 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the docs! it's been interesting following along the journey :-)
maybe a silly question, why do we expect performance numbers to be better than what we report?

@Fidget-SpinnerFidget-SpinnerMar 7, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The computed goto bug in theory shouldnt affect modern systems that much, but it's unclear for now so I just put that therr.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fidget-Spinner@bedevere-bot@hauntsaninja