Uh oh!
There was an error while loading. Please reload this page.
gh-127146: Fix Emscripten test suite when run with -uall - #132092
gh-127146: Fix Emscripten test suite when run with -uall#132092hoodmane wants to merge 3 commits into
Conversation
Emscripten large file support works fine and is required for `testZip64LargeFile` to work. And skip more stack overflows
freakboy3742
commented
Apr 7, 2025
Can confirm the test suite now completes for me without crashing. I'm seeing 2 test failures at runtime on the Buildbot machine (using emscripten 4.0.6, running and Are you seeing those failures as well? |
hoodmane
commented
Apr 7, 2025
Nope. Did you run it on this specific commit? The sysconfigdata failure I was seeing in the fall but @FFY00 made some changes that made it go away for me a couple months ago. Is the |
hoodmane
commented
Apr 7, 2025
I will double check everything in my setup and rerun the tests. |
hoodmane
commented
Apr 7, 2025
I can reproduce the |
hoodmane
commented
Apr 7, 2025
I sometimes get: But I cannot reproduce the |
freakboy3742
commented
Apr 7, 2025
I've run it twice with 3d49b34, and once with f36c496, and it has failed all three times. Updating to f36c496 has resolved the sysconfig issue, though. I have tried to reproduce the failure locally, but the hotel wifi I'm on is currently blocking downloads from GitHub 🙄 . I'll be at a different hotel in about 12 hours, so I can try again there. |
freakboy3742
commented
Apr 8, 2025
I've finally got a chance to test this locally, and I'm seeing the same problem (running on macOS). |
hoodmane
commented
Apr 8, 2025
You okay to skip it and investigate later? |
freakboy3742
commented
Apr 8, 2025
I'm not wild about merging an open ended TODO; and given it will be about a week before I'll have a chance to focus on getting the buildbot in place, and this is literally the last piece before we have a clean test run, I'd rather do at least a preliminary investigation so we've got an idea how deep this hole goes. |
hoodmane
commented
Apr 8, 2025
Sounds good. I just wish I could reproduce it. I'll try cleaning everything and rebuild again. |
Emscripten large file support works fine and is required for
testZip64LargeFileto work.And skip more stack overflows
@freakboy3742