Skip to content

gh-132097: use a macro for semantically casting function pointers - #132406

Merged
picnixz merged 8 commits into
python:mainfrom
picnixz:feat/ubsan/explicit-conversions
Apr 18, 2025
Merged

gh-132097: use a macro for semantically casting function pointers#132406
picnixz merged 8 commits into
python:mainfrom
picnixz:feat/ubsan/explicit-conversions

Conversation

@picnixz

@picnixzpicnixz commented Apr 11, 2025

Copy link
Copy Markdown
Member

This is typically useful when one needs to find if a cast is needed or not.

@picnixzpicnixz changed the title gh-132097: use explicit macro for semantically casting function pointersgh-132097: use a macro for semantically casting function pointersApr 11, 2025
Comment threadInclude/methodobject.h Outdated
Comment threadInclude/pyport.h
picnixzand others added 3 commits April 18, 2025 10:17
Co-authored-by: Victor Stinner <vstinner@python.org>
@picnixz
picnixz marked this pull request as ready for review April 18, 2025 08:26
@picnixz

Copy link
Copy Markdown
MemberAuthor

!buildbot EMScripten

@bedevere-bot

Copy link
Copy Markdown

The regex 'EMScripten' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadInclude/pyport.h
Co-authored-by: Victor Stinner <vstinner@python.org>
@picnixz

Copy link
Copy Markdown
MemberAuthor

Hum, ideally I wanted to be sure that this change won't be bad for EMScripten but hopefully it won't.

@hoodmane Can you confirm that this won't be breaking EMScripten builds? (and do we have a build bot for it?)

@picnixzpicnixz self-assigned this Apr 18, 2025
@hoodmane

hoodmane commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

It looks fine to me. No build bot still, we have to merge #132092 first.

Thanks for the ping @picnixz !

@picnixz
picnixz merged commit 3793526 into python:mainApr 18, 2025
@picnixz
picnixz deleted the feat/ubsan/explicit-conversions branch April 18, 2025 10:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@bedevere-bot@hoodmane@vstinner