Skip to content

gh-133117: Run mypy on tomllib in CI - #133118

Merged
sobolevn merged 3 commits into
python:mainfrom
sobolevn:mypy-tomllib
Apr 30, 2025
Merged

gh-133117: Run mypy on tomllib in CI#133118
sobolevn merged 3 commits into
python:mainfrom
sobolevn:mypy-tomllib

Conversation

@sobolevn

@sobolevnsobolevn commented Apr 28, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Apr 28, 2025
Closed
hugovk
hugovk reviewed Apr 29, 2025
View reviewed changes
Comment thread.github/workflows/mypy.yml Outdated
Comment thread.github/workflows/mypy.yml Outdated
Comment threadLib/tomllib/_parser.py Outdated

def __init__(self) -> None:
self._flags: dict[str, dict] = {}
self._flags: dict[str, dict[Any, Any]] = {}

@hugovkhugovkApr 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fully typed already, we just need to run the CI if something changes.

Seems it wasn't fully typed already?

Please can you also submit these changes to https://github.com/hukkin/tomli ?

@sobolevnsobolevnApr 29, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do it before or after this PR?

@hugovkhugovkApr 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest there first, because we're sort of downstream, but no strong preference from me.

Let's ask @hukkin, @encukou and @hauntsaninja.

@sobolevnsobolevnApr 29, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: hukkin/tomli#257

@sobolevnsobolevn mentioned this pull request Apr 29, 2025
Merged
AlexWaygood
AlexWaygood reviewed Apr 29, 2025
View reviewed changes
Comment threadLib/tomllib/mypy.ini Outdated
@sobolevn

sobolevn commented Apr 29, 2025

Copy link
Copy Markdown
MemberAuthor

merging main so CLA can possibly get unstuck :(

@sobolevn

sobolevn commented Apr 29, 2025

Copy link
Copy Markdown
MemberAuthor

I will keep this open for a day or so, waiting for others' feedback :)

@sobolevn
sobolevn merged commit 5ea9010 into python:mainApr 30, 2025
@miss-islington-app

miss-islington-appBot commented Apr 30, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2025
@sobolevn@miss-islington
pythongh-133117: Run mypy ontomllibin CI (pythonGH-133118)
b9259e1
(cherry picked from commit 5ea9010)
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Apr 30, 2025

Copy link
Copy Markdown

GH-133192 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 30, 2025
@sobolevn

sobolevn commented Apr 30, 2025

Copy link
Copy Markdown
MemberAuthor

Now I will work on enabling disallow_any_generics = True, thanks everyone!

sobolevn added a commit that referenced this pull request Apr 30, 2025
@miss-islington@sobolevn
[3.13]gh-133117: Run mypy ontomllibin CI (GH-133118) (#133192)
0458554
gh-133117: Run mypy on `tomllib` in CI (GH-133118)
(cherry picked from commit 5ea9010)
Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevnsobolevn mentioned this pull request Apr 30, 2025
Merged
@sobolevnsobolevn mentioned this pull request May 11, 2025
Merged
@eli-schwartz

eli-schwartz commented Jun 16, 2025

Copy link
Copy Markdown
Contributor
 * CMP: =dev-lang/python-3.14.0_alpha6 with dev-lang/python-3.14.0_beta2_p1/image
[...]
* FILES:+usr/lib/python3.14/tomllib/mypy.ini
[...]

This PR seems to have caused a new file to be installed by make install. The file is likely quite useless outside of the git repo.

@sobolevn

sobolevn commented Jun 16, 2025

Copy link
Copy Markdown
MemberAuthor

@eli-schwartz let's discuss this separatelly :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@ambvambvAwaiting requested review from ambv
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstra
@encukouencukouAwaiting requested review from encukouencukou is a code owner
@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninjahauntsaninja is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@eli-schwartz@hugovk@AlexWaygood