Skip to content

gh-133117: Enable stricter mypy checks for tomllib - #133206

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-133117-2
May 3, 2025
Merged

gh-133117: Enable stricter mypy checks for tomllib#133206
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-133117-2

Conversation

@sobolevn

@sobolevnsobolevn commented Apr 30, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Apr 30, 2025
Closed
@AlexWaygood

AlexWaygood commented Apr 30, 2025

Copy link
Copy Markdown
Member

I support this but I'm not sure if it makes sense to merge it prior to hukkin/tomli#257? Might it not cause problems if the two codebases get out of sync?

I'll defer to @hukkin / @hauntsaninja / @encukou as the tomllib maintainers :-)

@AlexWaygood
AlexWaygood removed their request for review April 30, 2025 13:39
@sobolevn

sobolevn commented May 1, 2025

Copy link
Copy Markdown
MemberAuthor

hukkin/tomli#257 was merged. The only difference with this PR is that here we still use --incremental, I think it is more important for us, since the scale of the project and the fact that we don't have any extra configs.

cc @hukkin

@sobolevn

sobolevn commented May 2, 2025

Copy link
Copy Markdown
MemberAuthor

Going to merge this tomorrow :)

@sobolevn
sobolevn merged commit cb31741 into python:mainMay 3, 2025
@miss-islington-app

miss-islington-appBot commented May 3, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 3, 2025
@sobolevn@miss-islington
pythongh-133117: Enable stricter mypy checks fortomllib(pythonGH-…
044e36d
…133206)
(cherry picked from commit cb31741)
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented May 3, 2025

Copy link
Copy Markdown

GH-133343 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 3, 2025
sobolevn added a commit that referenced this pull request May 3, 2025
@miss-islington@sobolevn
[3.13]gh-133117: Enable stricter mypy checks fortomllib(GH-133206)…
8525223
… (#133343)
gh-133117: Enable stricter mypy checks for `tomllib` (GH-133206)
(cherry picked from commit cb31741)
Co-authored-by: sobolevn <mail@sobolevn.me>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn@Pranjal095
pythongh-133117: Enable stricter mypy checks fortomllib(python#13…
5d1e85a
…3206)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouAwaiting requested review from encukouencukou is a code owner
@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninjahauntsaninja is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@AlexWaygood