gh-133439: Fix the error message in the sqlite3 CLI by StanFromIreland · Pull Request #133807 · python/cpython

StanFromIreland · 2025-05-10T07:37:17Z

Use print for file consistency
Actually test for the full improved error message
Correct error message, messages do not have the '.'

Issue: sqlite3 CLI does not recognize dot commands with trailing spaces #133439

picnixz

I don't think this PR is needed anymore, except maybe for the assertIn

StanFromIreland · 2025-05-10T08:06:44Z

Should the error message not be consistent with all other cpython error messages?

I think it is still better to use print for clarity (we don't have to look it up) and consistency, all other writing in the file is done so.

picnixz · 2025-05-10T08:13:37Z

I think it is still better to use print for clarity (we don't have to look it up) and consistency, all other writing in the file is done so.

I guess so. I actually expected InteractiveConsole to have a write_stderr and a write_stdout but there's none, so maybe only using print makes sense. WDYT @erlend-aasland?

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

StanFromIreland · 2025-06-12T15:15:42Z

While working on something else I realized the current error message is error-ed even more:

sqlite> .HELP Error: unknowncommand or invalid arguments: "HELP".

Friendly ping @erlend-aasland

erlend-aasland · 2025-06-13T16:49:38Z

Stan, did you want to include further amendments in this PR?

StanFromIreland · 2025-06-13T17:04:46Z

I don't mind, I can include it here. All that is to be done for the . help is to just use .rstrip instead of .strip.

This reverts commit 97d002d.

This reverts commit c2ed7f1.

serhiy-storchaka · 2025-06-13T17:48:12Z

 t = theme.traceback
- self.write(f'{t.type}Error{t.reset}:{t.message} unknown'
- f'command or invalid arguments: "{unknown}".\n{t.reset}')
+ print(f'{t.type}Error{t.reset}:{t.message} unknown command '


Note that the banner and tracebacks are written using self.write(). Why not use it here for consistence?

Errors (35) use print? And so do the other match statements branches.

Other branches output to stdout.
Line 35 perhaps should use self.write() too.

We can leave execute() for now. It is not worth to rewrite it just for this.

Suggested change
print(f'{t.type}Error{t.reset}:{t.message} unknown command '
self.write(f'{t.type}Error{t.reset}:{t.message} unknown command '
It is up to you/Erlend. The box to allow you to commit was checked.

miss-islington-app · 2025-06-19T11:46:37Z

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2025-06-19T11:46:40Z

Sorry, @StanFromIreland and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ecd83e02b128bf0879d9bb1d3940e40bcb14bdc6 3.14

StanFromIreland · 2025-06-19T12:28:10Z

The original was "backported" to 3.13 but it seems it was modified:

cpython/Lib/sqlite3/__main__.py

Lines 64 to 65 in 55a34a1

self.write("Error: unknown command or invalid arguments:"
f' "{unknown}".\n') 

@encukou Should we backport this (to 3.13) too so they are the same?

bedevere-app · 2025-06-19T12:32:31Z

GH-135708 is a backport of this pull request to the 3.14 branch.

…honGH-133807) (cherry picked from commit ecd83e0) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

encukou · 2025-06-19T12:57:22Z

Now that I look at the diff, I don't see a bug to fix in 3.14.

StanFromIreland · 2025-06-19T13:06:46Z

There is no bug because the author modified the backport, the message is different though.

…33807) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Fixup pr
6b59a0b

StanFromIreland requested review from berkerpeksag and erlend-aasland as code owners May 10, 2025 07:37

bedevere-appBot mentioned this pull request May 10, 2025
sqlite3 CLI does not recognize dot commands with trailing spaces #133439
Closed

bedevere-appBot added the awaiting review label May 10, 2025

Merge branch 'main' into sqlite3-fixup
6980619

StanFromIreland mentioned this pull request May 10, 2025
gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface #133440
Merged

picnixz reviewed May 10, 2025
View reviewed changes

picnixz added the skip news label May 10, 2025

picnixz changed the title ~~gh-133439: Fixup sqlite3 changes in 133440~~gh-133439: simplify how errors are reported by sqlite3 CLIMay 10, 2025

picnixz reviewed May 10, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py Outdated
Comment threadLib/test/test_sqlite3/test_cli.py Outdated

Benedikts suggestion
6cb0432

picnixz reviewed May 10, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py Outdated

Update Lib/sqlite3/__main__.py
1c6cf80
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

StanFromIreland requested a review from picnixz May 10, 2025 08:34

picnixz approved these changes May 10, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels May 10, 2025

picnixz added the needs backport to 3.14 bugs and security fixes label May 10, 2025

StanFromIreland mentioned this pull request Jun 13, 2025
Colorize sqlite3 CLI #133447
Closed

erlend-aasland self-assigned this Jun 13, 2025

erlend-aasland approved these changes Jun 13, 2025
View reviewed changes

Use rstrip
97d002d

serhiy-storchaka reviewed Jun 13, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py Outdated

Adding the test file would be a good idea
c2ed7f1

StanFromIreland added 2 commits June 13, 2025 18:33

Revert "Use rstrip"
7170ad9
This reverts commit 97d002d.

Revert "Adding the test file would be a good idea"
fed7c0a
This reverts commit c2ed7f1.

StanFromIreland requested a review from serhiy-storchaka June 13, 2025 17:34

serhiy-storchaka reviewed Jun 13, 2025
View reviewed changes

serhiy-storchaka changed the title ~~gh-133439: simplify how errors are reported by sqlite3 CLI~~gh-133439: Fix the error message in the sqlite3 CLIJun 13, 2025

serhiy-storchaka reviewed Jun 14, 2025
View reviewed changes

Comment threadLib/sqlite3/__main__.py Outdated

serhiy-storchaka reviewed Jun 14, 2025
View reviewed changes

Comment threadLib/test/test_sqlite3/test_cli.py Outdated

Apply suggestions from code review
e8fde8d

serhiy-storchaka reviewed Jun 14, 2025
View reviewed changes

Comment threadLib/test/test_sqlite3/test_cli.py Outdated

Update Lib/test/test_sqlite3/test_cli.py
4dcd379

StanFromIreland mentioned this pull request Jun 19, 2025
gh-133934: Improve sqlite3 .help message #135224
Merged

encukou merged commit ecd83e0 into python:mainJun 19, 2025

bedevere-appBot removed the awaiting merge label Jun 19, 2025

miss-islington-appBot assigned encukou and unassigned erlend-aasland Jun 19, 2025

encukou assigned StanFromIreland and unassigned encukou Jun 19, 2025

bedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 19, 2025

StanFromIreland deleted the sqlite3-fixup branch June 19, 2025 12:33

	print(f'{t.type}Error{t.reset}:{t.message} unknown command '
	self.write(f'{t.type}Error{t.reset}:{t.message} unknown command '

Uh oh!

Uh oh!

Conversation

StanFromIreland commented May 10, 2025• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

StanFromIreland commented May 10, 2025

Uh oh!

picnixz commented May 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIreland commented Jun 12, 2025

Uh oh!

erlend-aasland commented Jun 13, 2025

Uh oh!

StanFromIreland commented Jun 13, 2025

Uh oh!

Uh oh!

serhiy-storchakaJun 13, 2025

Choose a reason for hiding this comment

Uh oh!

StanFromIrelandJun 13, 2025

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaJun 13, 2025

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaJun 13, 2025

Choose a reason for hiding this comment

Uh oh!

StanFromIrelandJun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-appBot commented Jun 19, 2025

Uh oh!

miss-islington-appBot commented Jun 19, 2025

Uh oh!

StanFromIreland commented Jun 19, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-appBot commented Jun 19, 2025

Uh oh!

encukou commented Jun 19, 2025

Uh oh!

StanFromIreland commented Jun 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

StanFromIreland commented May 10, 2025•
edited by bedevere-app Bot
Loading

picnixz commented May 10, 2025•
edited
Loading

StanFromIreland commented Jun 19, 2025•
edited
Loading