Uh oh!
There was an error while loading. Please reload this page.
bpo-36889: Make StreamServer.close() tests more robust - #13790
Merged
Conversation
ambv
commented
Jun 3, 2019
Contributor
@vstinner, look at this. |
1st1
approved these changes
Jun 4, 2019
asvetlov
commented
Jun 4, 2019
ContributorAuthor
Thanks, @1st1 |
vstinner
commented
Jun 4, 2019
Member
This change fixed https://bugs.python.org/issue37142 if I understood correctly. |
asvetlov
commented
Jun 4, 2019
ContributorAuthor
Yes, you are right. |
DinoV pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are reports about hanging stream tests on buildbots.
This PR rewrites tests for
StreamServer.close()It uses more future objects for fine-grained synchronization between client and server parts of tests.
https://bugs.python.org/issue36889