Uh oh!
There was an error while loading. Please reload this page.
bpo-37142: Make stream tests more robust again. - #13804
Merged
Merged
Conversation
Make test_stream_server_close() implementation following test_stream_server_abort(). Add explicit timeout for tests that can hang.
asvetlov
commented
Jun 4, 2019
ContributorAuthor
Sorry, I forgot apply changes done by #13790 to test_stream_server_close itself. Also, the PR adds the explicit 1min timeout for tests to fail fast |
vstinner
commented
Jun 4, 2019
Member
LGTM. I merged your PR @asvetlov, thanks. |
asvetlov
commented
Jun 4, 2019
ContributorAuthor
Thanks, @vstinner |
DinoV pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Make test_stream_server_close() implementation following test_stream_server_abort(). Add explicit timeout for tests that can hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make test_stream_server_close() implementation following test_stream_server_abort().
Add explicit timeout for tests that can hang.
https://bugs.python.org/issue37142