Skip to content

gh-139817: Attribute __qualname__ is added to TypeAliasType - #139919

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
efimov-mikhail:issue-139817-type-alias-qualname
Oct 15, 2025
Merged

gh-139817: Attribute __qualname__ is added to TypeAliasType#139919
JelleZijlstra merged 8 commits into
python:mainfrom
efimov-mikhail:issue-139817-type-alias-qualname

Conversation

@efimov-mikhail

@efimov-mikhailefimov-mikhail commented Oct 10, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 10, 2025
Closed
@efimov-mikhailefimov-mikhail changed the title gh-139817: Parameter __qualname__ is added to TypeAliasTypegh-139817: Attribute __qualname__ is added to TypeAliasTypeOct 10, 2025
@efimov-mikhail

efimov-mikhail commented Oct 10, 2025

Copy link
Copy Markdown
MemberAuthor

CC @sobolevn

@efimov-mikhail

efimov-mikhail commented Oct 10, 2025

Copy link
Copy Markdown
MemberAuthor

I'm totally not sure that this solution is fully correct.
But it works in typical situations, and improves introspection.

JelleZijlstra
JelleZijlstra reviewed Oct 11, 2025
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadObjects/typevarobject.c
Comment threadObjects/typevarobject.c
Comment threadLib/test/test_type_aliases.py
@efimov-mikhail

efimov-mikhail commented Oct 11, 2025

Copy link
Copy Markdown
MemberAuthor

I've added some tests on __name__ and __qualname__, docs and news

@AlexWaygood
AlexWaygood removed their request for review October 11, 2025 23:56
JelleZijlstra
JelleZijlstra reviewed Oct 12, 2025
View reviewed changes
Comment threadObjects/typevarobject.c Outdated
@efimov-mikhail

efimov-mikhail commented Oct 12, 2025

Copy link
Copy Markdown
MemberAuthor

I've added new constructor parameter: X = TypeAliasType("X", int, qualname="foo.X"). It looks like there is no much extra complexity and this solution is OK. But we can provide another variant, if it's needed.

JelleZijlstra
JelleZijlstra reviewed Oct 12, 2025
View reviewed changes
Comment threadObjects/typevarobject.c
@efimov-mikhailefimov-mikhail mentioned this pull request Oct 12, 2025
Merged
@efimov-mikhail

efimov-mikhail commented Oct 15, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Sorry for ping, @JelleZijlstra.

This PR could be merged, or I've missed something?

@JelleZijlstra
JelleZijlstra merged commit f673f0e into python:mainOct 15, 2025
45 checks passed
@efimov-mikhail

efimov-mikhail commented Oct 15, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks!

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@efimov-mikhail@StanFromIreland
pythongh-139817: Attribute__qualname__is added toTypeAliasType(…
13369a1
…python#139919)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@efimov-mikhail@JelleZijlstra