Uh oh!
There was an error while loading. Please reload this page.
gh-140000: Traverse name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec - #140016
Merged
Merged
Conversation
name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpecname attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpecUh oh!
There was an error while loading. Please reload this page.
efimov-mikhail
commented
Oct 13, 2025
MemberAuthor
I've added news entry, CI is green |
sergey-miryanov
approved these changes
Oct 13, 2025
kumaraditya303
approved these changes
Oct 13, 2025
Thanks @efimov-mikhail for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 13, 2025
…le`, `TypeAliasType`, `ParamSpec` (pythonGH-140016) (cherry picked from commit be60e4b) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Sorry, @efimov-mikhail and @JelleZijlstra, I could not cleanly backport this to |
GH-140063 is a backport of this pull request to the 3.14 branch. |
GH-140073 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure should we add tests on these.
But I've checked code snippet from the issue on all 4 types, they work as expected.
IMO, it'd be better to merge this PR first and provide a backports for 3.14 and 3.13.
We could merge #139919 after this (qualname traversing will be there).
cc @JelleZijlstra