Skip to content

gh-76007: pydoc: Catch DeprecationWarning for stdlib module __version__ attributes - #139997

Merged
hugovk merged 8 commits into
python:mainfrom
StanFromIreland:pydoc-warnings
Dec 14, 2025
Merged

gh-76007: pydoc: Catch DeprecationWarning for stdlib module __version__ attributes#139997
hugovk merged 8 commits into
python:mainfrom
StanFromIreland:pydoc-warnings

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Oct 12, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 12, 2025
Closed
picnixz
picnixz reviewed Oct 12, 2025
View reviewed changes
Comment threadLib/pydoc.py Outdated
picnixz
picnixz reviewed Oct 12, 2025
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests for that? (to see that we indeed don't catch the warning)

Comment threadLib/pydoc.py Outdated
Comment threadLib/pydoc.py Outdated
Comment threadLib/pydoc.py Outdated
Comment threadLib/pydoc.py Outdated
picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
Comment threadLib/test/test_pydoc/test_pydoc.py Outdated
Comment threadLib/test/test_pydoc/test_pydoc.py Outdated
picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
Comment threadLib/test/test_pydoc/test_pydoc.py Outdated
Comment threadLib/test/test_pydoc/test_pydoc.py Outdated
Comment threadLib/test/test_pydoc/test_pydoc.py Outdated
Comment threadLib/pydoc.py Outdated
picnixz
picnixz approved these changes Oct 13, 2025
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll let Adam have a look to see if he wants something different as well.

@StanFromIreland

StanFromIreland commented Oct 13, 2025

Copy link
Copy Markdown
MemberAuthor

Renaming MyModule to TestModule? ;-)

picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
Comment threadLib/test/test_pydoc/test_pydoc.py
@StanFromIrelandStanFromIreland mentioned this pull request Oct 13, 2025
Merged
@hugovk
hugovk merged commit 78a50ee into python:mainDec 14, 2025
45 checks passed
@StanFromIreland
StanFromIreland deleted the pydoc-warnings branch December 14, 2025 13:10
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@StanFromIreland@fatelei
pythongh-76007:pydoc: CatchDeprecationWarningfor stdlib module…
91f5dfe
… `__version__` attributes (python#139997)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@picnixz@hugovk@nazeerali4325-commits