gh-140080: Fix atexit with low memory by yihong0618 · Pull Request #140103 · python/cpython

yihong0618 · 2025-10-14T11:46:38Z

fix the error that's forget the cleanup

cc @ZeroIntensity @picnixz and it also turns out its not the _testcapi_setnomemroy(0) issue.

seems the news can skip?

after this patch no hang anymore

Issue: The REPL hangs under low memory on main #140080

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

ZeroIntensity

Since the 3.15 alpha is today, please add a news entry so we can know what was fixed in the next release.

Also, per usual, this needs a test case. At a glance, this should be reproducible by calling set_nomemory after registering an atexit callback.

yihong0618 · 2025-10-14T12:11:27Z

Since the 3.15 alpha is today, please add a news entry so we can know what was fixed in the next release.
Also, per usual, this needs a test case. At a glance, this should be reproducible by calling set_nomemory after registering an atexit callback.

of course will try, but the test things maybe need some help( - -)
will try it.

and also bring the 3.13(no_memory) tests is that under plan need to add in this pull request?

ZeroIntensity · 2025-10-14T12:13:20Z

and also bring the 3.13(no_memory) tests is that under plan need to add in this pull request?

Let's do that in a different PR, because we'll want that in 3.14 as well.

yihong0618 · 2025-10-14T12:13:52Z

and also bring the 3.13(no_memory) tests is that under plan need to add in this pull request?
Let's do that in a different PR, because we'll want that in 3.14 as well.

ok will do it later, thank you for the help~

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 · 2025-10-14T12:45:44Z

Since the 3.15 alpha is today, please add a news entry so we can know what was fixed in the next release.
Also, per usual, this needs a test case. At a glance, this should be reproducible by calling set_nomemory after registering an atexit callback.

Done, before the patch the tests hangs
after the patch the tests pas

tests from #138491

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

Co-authored-by: Victor Stinner <vstinner@python.org>

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

vstinner

LGTM

vstinner

Python 3.13 is not affected, atexit doesn't use PyObject *copy = PyList_GetSlice(state->callbacks, 0, PyList_GET_SIZE(state->callbacks)); in this version.

yihong0618 · 2025-10-15T13:23:16Z

Python 3.13 is not affected, atexit doesn't use PyObject *copy = PyList_GetSlice(state->callbacks, 0, PyList_GET_SIZE(state->callbacks)); in this version.

FYI: 3.14 not hang
and #136004 this patch seems did not backport to it.

yihong0618 · 2025-10-15T13:23:27Z

LGTM

Thank you!

ZeroIntensity

Yeah, this doesn't affect 3.14, so we shouldn't backport it there.

@yihong0618 After this is merged, would you mind creating a PR to 3.14 with the test from this PR?

yihong0618 · 2025-10-15T13:48:45Z

Yeah, this doesn't affect 3.14, so we shouldn't backport it there.
@yihong0618 After this is merged, would you mind creating a PR to 3.14 with the test from this PR?

of course with pleasure to do it thank you

vstinner · 2025-10-15T14:11:59Z

Why not backporting this change to 3.14?

ZeroIntensity · 2025-10-15T15:22:47Z

Why not backporting this change to 3.14?

On 3.14, we don't execute atexit callbacks in a loop, so if PyList_GetSlice fails, it will correctly bail out and continue with finalization.

…s during finalization (pythonGH-140103) This fixes a regression introduced by pythonGH-136004, in which finalization would hang while executing atexit handlers if the system was out of memory. --------- Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

fix: atexit_cleanup the state
7cdfb7c
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

bedevere-appBot added the awaiting review label Oct 14, 2025

yihong0618 changed the title ~~fix: atexit_cleanup the state~~gh-140080: atexit_cleanup the stateOct 14, 2025

bedevere-appBot mentioned this pull request Oct 14, 2025
The REPL hangs under low memory on main #140080
Closed

ZeroIntensity reviewed Oct 14, 2025
View reviewed changes

fix: add news and tests
da72a0b
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 requested a review from iritkatriel as a code owner October 14, 2025 12:44

yihong0618 requested a review from ZeroIntensity October 14, 2025 14:08

ZeroIntensity reviewed Oct 14, 2025
View reviewed changes

Comment threadMisc/NEWS.d/next/Core_and_Builtins/2025-10-14-20-18-31.gh-issue-140080.8ROjxW.rst Outdated
Comment threadLib/test/test_exceptions.py
Comment threadLib/test/test_exceptions.py Outdated
Comment threadModules/atexitmodule.c Outdated
Comment threadLib/test/test_exceptions.py Outdated

yihong0618and others added 2 commits October 14, 2025 22:17

Apply suggestions from code review
0f0cbef
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

fix: move tests to atexit
d664393
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 requested a review from ZeroIntensity October 14, 2025 14:30

yihong0618 added 2 commits October 14, 2025 22:31

fix: empty line drop
b9af102
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: use assert not in instead
2e2e467
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

ZeroIntensity reviewed Oct 14, 2025
View reviewed changes

Comment threadLib/test/test_atexit.py Outdated
Comment threadLib/test/test_atexit.py Outdated

yihong0618 added 2 commits October 14, 2025 22:42

fix: address comments
60d200e
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: use temp here
8d3c3a8
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 requested a review from ZeroIntensity October 14, 2025 14:51

yihong0618 added 2 commits October 14, 2025 23:01

fix: ingore not requires_subprocess
5e288a2
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: use spawn_python
42f90ab
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

vstinner reviewed Oct 14, 2025
View reviewed changes

Comment threadLib/test/test_atexit.py Outdated
Comment threadLib/test/test_atexit.py Outdated

yihong0618and others added 2 commits October 15, 2025 07:48

Update Lib/test/test_atexit.py
294e404
Co-authored-by: Victor Stinner <vstinner@python.org>

fix: apply comments
1958a7a
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

vstinner reviewed Oct 14, 2025
View reviewed changes

Comment threadLib/test/test_atexit.py Outdated

yihong0618 added 2 commits October 15, 2025 07:54

fix: indentation level for test code in test
7ab0231
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: use test helper function
00b5a8c
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 requested a review from vstinner October 15, 2025 05:51

vstinner approved these changes Oct 15, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels Oct 15, 2025

vstinner added the needs backport to 3.14 bugs and security fixes label Oct 15, 2025

vstinner reviewed Oct 15, 2025
View reviewed changes

vstinner changed the title ~~gh-140080: atexit_cleanup the state~~gh-140080: Fix atexit with low memoryOct 15, 2025

ZeroIntensity removed the needs backport to 3.14 bugs and security fixes label Oct 15, 2025

ZeroIntensity approved these changes Oct 15, 2025
View reviewed changes

ZeroIntensity merged commit a05aece into python:mainOct 15, 2025
53 checks passed

bedevere-appBot removed the awaiting merge label Oct 15, 2025

yihong0618 mentioned this pull request Oct 15, 2025
[3.14] gh-140080: chore test test_atexit_with_low_memory from main #140161
Merged

yihong0618 mentioned this pull request Oct 16, 2025
gh-140193: Forward port test_exec_set_nomemory_hang from 3.13 #140187
Merged

Uh oh!

Uh oh!

Conversation

yihong0618 commented Oct 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

yihong0618 commented Oct 14, 2025

Uh oh!

ZeroIntensity commented Oct 14, 2025

Uh oh!

yihong0618 commented Oct 14, 2025

Uh oh!

yihong0618 commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

yihong0618 commented Oct 15, 2025

Uh oh!

yihong0618 commented Oct 15, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

yihong0618 commented Oct 15, 2025

Uh oh!

Uh oh!

vstinner commented Oct 15, 2025

Uh oh!

ZeroIntensity commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yihong0618 commented Oct 14, 2025•
edited
Loading