Uh oh!
There was an error while loading. Please reload this page.
gh-140193: Forward port test_exec_set_nomemory_hang from 3.13 - #140187
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
commented
Oct 16, 2025
Can you make an issue for that change please? |
of course Done |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM, but let's run buildbots before merging this.
bedevere-bot
commented
Oct 16, 2025
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 3f31156 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140187%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
yihong0618
commented
Oct 16, 2025
2000 is too long for windows... |
ZeroIntensity
commented
Oct 16, 2025
Can you figure out which number will get the |
yihong0618
commented
Oct 16, 2025
will do it tomorrow~ good night. |
yihong0618
commented
Oct 17, 2025
will be 60 times for 59 times [hyi@rocky cpython]$ gdb ./python
GNU gdb (Rocky Linux) 14.2-3.el9
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "aarch64-redhat-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./python...
warning: File "/home/hyi/cpython/python-gdb.py" auto-loading has been declined by your `auto-load safe-path' set to "$debugdir:$datadir/auto-load".To enable execution of this file add add-auto-load-safe-path /home/hyi/cpython/python-gdb.pyline to your configuration file "/home/hyi/.gdbinit".To completely disable this security protection add set auto-load safe-path /line to your configuration file "/home/hyi/.gdbinit".For more information about this security protection see the"Auto-loading safe path" section in the GDB manual. E.g., run from the shell: info "(gdb)Auto-loading safe path"(gdb) b ceval.c:913 if $has_import_traceback()Breakpoint 1 at 0x6ae4dc: file Python/ceval.c, line 913.(gdb) set args ttt.py (gdb) runStarting program: /home/hyi/cpython/python ttt.py [Thread debugging using libthread_db enabled]Using host libthread_db library "/lib64/libthread_db.so.1".Breakpoint 1, _PyEval_EvalFrameDefault (tstate=0xaf5020 <_PyRuntime+299056>, frame=0xfffff7cf5020, throwflag=0) at Python/ceval.c:913913 PyObject *lasti = PyLong_FromLong(frame_lasti);(gdb) p frame_lasti$1 = 933for 60 times for gdb script pythonimportgdbclasshas_import_traceback(gdb.Function):
"""Return 1 if 'import traceback' appears in py-bt output, else 0."""def__init__(self):
super().__init__("has_import_traceback")
definvoke(self):
try:
out=gdb.execute("py-bt", to_string=True)
exceptgdb.error:
returngdb.Value(0)
returngdb.Value(1if"import traceback"inoutelse0)
has_import_traceback()
end |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
bedevere-bot
commented
Nov 11, 2025
🤖 New build scheduled with the buildbot fleet by @gpshead for commit cc4da89 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140187%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
commented
Nov 11, 2025
🤖 New build scheduled with the buildbot fleet by @gpshead for commit cc4da89 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140187%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading. Please reload this page.
Thanks @yihong0618 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ythonGH-140187) * chore: test_exec_set_nomemory_hang from 3.13 Signed-off-by: yihong0618 <zouzou0208@gmail.com> * fix: apply comments Signed-off-by: yihong0618 <zouzou0208@gmail.com> * Update Lib/test/test_exceptions.py Co-authored-by: Peter Bierma <zintensitydev@gmail.com> * Update Lib/test/test_exceptions.py Co-authored-by: Peter Bierma <zintensitydev@gmail.com> * fix: windows too long name 60 times is enough Signed-off-by: yihong0618 <zouzou0208@gmail.com> --------- (cherry picked from commit 0f09bda) Co-authored-by: yihong <zouzou0208@gmail.com> Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
GH-141420 is a backport of this pull request to the 3.14 branch. |
…H-140187) (#141420) gh-140193: Forward port test_exec_set_nomemory_hang from 3.13 (GH-140187) * chore: test_exec_set_nomemory_hang from 3.13 * fix: apply comments * Update Lib/test/test_exceptions.py * Update Lib/test/test_exceptions.py * fix: windows too long name 60 times is enough --------- (cherry picked from commit 0f09bda) Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: yihong <zouzou0208@gmail.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
bedevere-bot
commented
Nov 11, 2025
|
…ythonGH-140187) * chore: test_exec_set_nomemory_hang from 3.13 Signed-off-by: yihong0618 <zouzou0208@gmail.com> * fix: apply comments Signed-off-by: yihong0618 <zouzou0208@gmail.com> * Update Lib/test/test_exceptions.py Co-authored-by: Peter Bierma <zintensitydev@gmail.com> * Update Lib/test/test_exceptions.py Co-authored-by: Peter Bierma <zintensitydev@gmail.com> * fix: windows too long name 60 times is enough Signed-off-by: yihong0618 <zouzou0208@gmail.com> --------- Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
as discuss in #140103 (comment)
chore the test from branch 3.13 and need backport to 3.14
since main and 3.14 do not have the issue only test(so change the comments)
cc @ZeroIntensity