Skip to content

gh-76007: Deprecate zlib.__version__ attribute - #140130

Merged
vstinner merged 3 commits into
python:mainfrom
StanFromIreland:zlib-version
Oct 15, 2025
Merged

gh-76007: Deprecate zlib.__version__ attribute#140130
vstinner merged 3 commits into
python:mainfrom
StanFromIreland:zlib-version

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Oct 14, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 14, 2025
Closed
vstinner
vstinner reviewed Oct 14, 2025
View reviewed changes
Comment threadModules/zlibmodule.c Outdated
vstinner
vstinner reviewed Oct 14, 2025
View reviewed changes
Comment threadModules/zlibmodule.c Outdated
StanFromIreland
StanFromIreland commented Oct 15, 2025
View reviewed changes
Comment threadModules/zlibmodule.c Outdated
vstinner
vstinner approved these changes Oct 15, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadModules/zlibmodule.c
ZLIB_CRC32_COMBINE_METHODDEF
ZLIB_DECOMPRESS_METHODDEF
ZLIB_DECOMPRESSOBJ_METHODDEF
{"__getattr__", zlib_getattr, METH_VARARGS, "Module __getattr__"},

@vstinnervstinnerOct 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to convert the function to Argument Clinic, but it failed, oh!

Error in file 'Modules/zlibmodule.c' on line 2019:
'__getattr__' is a special method and cannot be converted to Argument Clinic!

@StanFromIrelandStanFromIrelandOct 15, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that too :-)

@merwokmerwokOct 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a valid feature request for AC or it’s somehow impossible?

@StanFromIrelandStanFromIrelandOct 19, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, and it is relatively straightforward (I based my implementation on METHOD_INIT's), here is a patch. I do not know if there was a reason for this not being done before, other than there not being a need, as it is explicitly in the unsupported list, maybe Victor knows more?

@vstinnervstinnerOct 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why it's not supported currently.

@StanFromIrelandStanFromIrelandOct 19, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the patch?

@vstinnervstinnerOct 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can propose it as a PR.

@StanFromIrelandStanFromIrelandOct 20, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #140376

@vstinner
vstinner merged commit 46f11b3 into python:mainOct 15, 2025
49 checks passed
@vstinner

vstinner commented Oct 15, 2025

Copy link
Copy Markdown
Member

Merged, thanks. I also saw that version but forgot to deprecate it :-)

@StanFromIreland
StanFromIreland deleted the zlib-version branch October 15, 2025 12:21
This was referenced Oct 19, 2025
Merged
Closed
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-76007: Deprecatezlib.__version__attribute (python#140130)
1ec053f
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@merwokmerwokmerwok left review comments
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@hugovkhugovkAwaiting requested review from hugovk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@vstinner@merwok