Skip to content

GH-65961: Stop setting or using __package__ on modules - #142046

Closed
brettcannon wants to merge 8 commits into
python:mainfrom
brettcannon:remove-__package__
Closed

GH-65961: Stop setting or using __package__ on modules#142046
brettcannon wants to merge 8 commits into
python:mainfrom
brettcannon:remove-__package__

Conversation

@brettcannon

@brettcannonbrettcannon commented Nov 28, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@brettcannon
Initial attempt
ff5fc7d
```
21 tests altered the execution environment (env changed):
test_logging test_pathlib test_profile test_pty test_pulldom
test_pwd test_pyclbr test_pyexpat test_pyrepl test_pystats
test_resource test_rlcompleter test_robotparser test_sax
test_sched test_secrets test_select test_set test_shlex test_str
test_thread
5 tests failed:
test_capi test_cmd_line_script test_importlib test_repl
test_sysconfig
```
@brettcannon
Fix test_importlib
d625711
@brettcannon
Merge branch 'main' of github.com:python/cpython into remove-__package__
7bfde50
@brettcannon
Fix test_cmd_line_script
ff7547f
@bedevere-appbedevere-appBot mentioned this pull request Nov 28, 2025
Open
@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

Currently a draft until the test_capi failure can somehow be resolved as I have no idea how what I'm doing is the direct cause of the failure.

@brettcannonbrettcannon mentioned this pull request Nov 28, 2025
Closed
@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

#142055 is an alternative to this PR where __package__ is no longer set, but is still supported.

@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

Yet again this project gets postponed, this time thanks to pip: https://github.com/pypa/pip/blob/36987b0c31b97ffb9fb7949ded628e9a6b10c016/src/pip/__main__.py#L13

@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

The test_capi test failure is still weird, regardless, but this PR is now dead in the water.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal will be requested when the pull request is marked ready for reviewpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou will be requested when the pull request is marked ready for reviewlysnikolaou is a code owner
@ambvambvAwaiting requested review from ambvambv will be requested when the pull request is marked ready for reviewambv is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner
@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian will be requested when the pull request is marked ready for reviewgaogaotiantian is a code owner
@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy will be requested when the pull request is marked ready for reviewterryjreedy is a code owner
@1st11st1Awaiting requested review from 1st11st1 will be requested when the pull request is marked ready for review1st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov will be requested when the pull request is marked ready for reviewasvetlov is a code owner
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 will be requested when the pull request is marked ready for reviewkumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc will be requested when the pull request is marked ready for reviewwillingc is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner
@FFY00FFY00Awaiting requested review from FFY00FFY00 will be requested when the pull request is marked ready for reviewFFY00 is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan will be requested when the pull request is marked ready for reviewncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw will be requested when the pull request is marked ready for reviewwarsaw is a code owner
@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity will be requested when the pull request is marked ready for reviewZeroIntensity is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brettcannon