Skip to content

GH-65961: Stop setting __package__ on modules - #142055

Closed
brettcannon wants to merge 5 commits into
python:mainfrom
brettcannon:__package__-optional
Closed

GH-65961: Stop setting __package__ on modules#142055
brettcannon wants to merge 5 commits into
python:mainfrom
brettcannon:__package__-optional

Conversation

@brettcannon

@brettcannonbrettcannon commented Nov 28, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Nov 28, 2025
Open
@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

This is an alternative to #142046 which doesn't even support using __package__.

@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

This is a draft PR until either someone can tell me what's going on with test_capi or a rip the test out because I don't see how I'm causing the failure in either this PR and #142046 .

@brettcannonbrettcannon mentioned this pull request Nov 28, 2025
Closed
ncoghlan
ncoghlan approved these changes Nov 28, 2025
View reviewed changes

@ncoghlanncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor cosmetic comment on the docs.

Comment threadDoc/reference/datamodel.rst Outdated
@brettcannon@ncoghlan
Update Doc/reference/datamodel.rst
d02a8d5
Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
@brettcannon

brettcannon commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

Unfortunately it looks like pip didn't get the memo about this upcoming change: https://github.com/pypa/pip/blob/36987b0c31b97ffb9fb7949ded628e9a6b10c016/src/pip/__main__.py#L13

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlanncoghlanncoghlan approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal will be requested when the pull request is marked ready for reviewpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou will be requested when the pull request is marked ready for reviewlysnikolaou is a code owner
@ambvambvAwaiting requested review from ambvambv will be requested when the pull request is marked ready for reviewambv is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner
@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian will be requested when the pull request is marked ready for reviewgaogaotiantian is a code owner
@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy will be requested when the pull request is marked ready for reviewterryjreedy is a code owner
@1st11st1Awaiting requested review from 1st11st1 will be requested when the pull request is marked ready for review1st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov will be requested when the pull request is marked ready for reviewasvetlov is a code owner
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 will be requested when the pull request is marked ready for reviewkumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc will be requested when the pull request is marked ready for reviewwillingc is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner
@FFY00FFY00Awaiting requested review from FFY00FFY00 will be requested when the pull request is marked ready for reviewFFY00 is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw will be requested when the pull request is marked ready for reviewwarsaw is a code owner
@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity will be requested when the pull request is marked ready for reviewZeroIntensity is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brettcannon@ncoghlan