Skip to content

compute-changes.py: Fix & test process_changed_files() - #144674

Merged
hugovk merged 3 commits into
python:mainfrom
StanFromIreland:compute-changes
Feb 19, 2026
Merged

compute-changes.py: Fix & test process_changed_files()#144674
hugovk merged 3 commits into
python:mainfrom
StanFromIreland:compute-changes

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Feb 10, 2026

Copy link
Copy Markdown
Member

No description provided.

webknjaz
webknjaz approved these changes Feb 11, 2026
View reviewed changes

@webknjazwebknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for the initial effort. I might've missed something, reviewing from mobile, though. It'd be good to get an additional set of eyes on the PR.

Comment threadLib/test/test_tools/test_compute_changes.py
hugovk
hugovk reviewed Feb 11, 2026
View reviewed changes
Comment threadLib/test/test_tools/test_compute_changes.py Outdated
Comment threadLib/test/test_tools/test_compute_changes.py Outdated
Comment threadLib/test/test_tools/test_compute_changes.py Outdated
Comment threadLib/test/test_tools/test_compute_changes.py Outdated
@StanFromIreland
Requested changes
476d106
Tá cosc ar an nGaeilge :-(
@webknjazwebknjaz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 11, 2026
@StanFromIrelandStanFromIreland mentioned this pull request Feb 19, 2026
Merged
chris-eibl
chris-eibl reviewed Feb 19, 2026
View reviewed changes
Comment threadLib/test/test_tools/test_compute_changes.py Outdated
@StanFromIreland@chris-eibl
Update Lib/test/test_tools/test_compute_changes.py
97c32dc
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@hugovk
hugovk merged commit 930b3fd into python:mainFeb 19, 2026
54 checks passed
@miss-islington-app

miss-islington-appBot commented Feb 19, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Feb 19, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 930b3fd1df67eea85d0b1e284d76cb1223ba05f8 3.14

@miss-islington-app

miss-islington-appBot commented Feb 19, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 930b3fd1df67eea85d0b1e284d76cb1223ba05f8 3.13

@bedevere-app

bedevere-appBot commented Feb 19, 2026

Copy link
Copy Markdown

GH-145013 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Feb 19, 2026
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Feb 19, 2026
@StanFromIreland@chris-eibl
[3.14]compute-changes.py: Fix & testprocess_changed_files()(py…
bd0f1b7
…thonGH-144674)
(cherry picked from commit 930b3fd)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Feb 19, 2026
@StanFromIreland@chris-eibl
[3.13]compute-changes.py: Fix & testprocess_changed_files()(py…
7fce1c6
…thonGH-144674)
(cherry picked from commit 930b3fd)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Feb 19, 2026

Copy link
Copy Markdown

GH-145014 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Feb 19, 2026
@StanFromIreland
StanFromIreland deleted the compute-changes branch February 19, 2026 18:53
hugovk pushed a commit that referenced this pull request Feb 21, 2026
@StanFromIreland@chris-eibl
[3.14]compute-changes.py: Fix & testprocess_changed_files()(GH…
8e482eb
…-144674) (#145013)
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Feb 21, 2026
@StanFromIreland@chris-eibl
[3.13]compute-changes.py: Fix & testprocess_changed_files()(GH…
773cd81
…-144674) (#145014)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@StanFromIreland@chris-eibl@brijkapadia
compute-changes.py: Fix & testprocess_changed_files()(python#14…
fed90e6
…4674)
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@StanFromIreland@chris-eibl@ljfp
compute-changes.py: Fix & testprocess_changed_files()(python#14…
692798c
…4674)
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjazwebknjazwebknjaz approved these changes
@hugovkhugovkhugovk approved these changes
@chris-eiblchris-eiblchris-eibl approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@hugovkhugovk

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@webknjaz@hugovk@chris-eibl