Skip to content

GH-144679: Upgrade to windows-2025-vs2026 in GitHub Actions - #145005

Merged
zooba merged 5 commits into
python:mainfrom
chris-eibl:windows-2025-vs2026
Feb 19, 2026
Merged

GH-144679: Upgrade to windows-2025-vs2026 in GitHub Actions#145005
zooba merged 5 commits into
python:mainfrom
chris-eibl:windows-2025-vs2026

Conversation

@chris-eibl

@chris-eiblchris-eibl commented Feb 19, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Per offline discussion with @zooba we'd like to switch over to VS2026 on main already now. In May windows-2025 will get VS2026, anyway.

Yeah, it's released and stable, so let's switch main over

Just the same changes that @vstinner did in #144682 for windows-2025.

@bedevere-appbedevere-appBot mentioned this pull request Feb 19, 2026
Closed
savannahostrowski
savannahostrowski approved these changes Feb 19, 2026
View reviewed changes

@savannahostrowskisavannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great! Thanks for doing this!

@StanFromIreland

StanFromIreland commented Feb 19, 2026

Copy link
Copy Markdown
Member

The Windows CI won't run till #144674 is merged.

@vstinner

vstinner commented Feb 19, 2026

Copy link
Copy Markdown
Member

The Windows CI won't run till #144674 is merged.

As a workaround, you can push a test change modifying a file in another directory, check the CI, and then revert this test change.

@hugovk

hugovk commented Feb 19, 2026

Copy link
Copy Markdown
Member

#144674 is now merged and I merged in main, so we can remove the dummy commit.

hugovk
hugovk approved these changes Feb 19, 2026
View reviewed changes
Comment threadLib/test/test___all__.py Outdated
@chris-eibl@hugovk
Update Lib/test/test___all__.py
d1a5a53
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@zooba

zooba commented Feb 19, 2026

Copy link
Copy Markdown
Member

v1950 is the compiler version you expect to see in sys.copyright after this change? (The builds don't seem to be using the -v flag, which is why you can't see the compiler commands as they build)

@chris-eibl

chris-eibl commented Feb 19, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Yeah, I've verified. You see it in the build logs when the tests start.

Edit: or in "Display build info"

sys.version: 3.15.0a6+ (remotes/pull/145005/merge:ee4fd43, Feb 19 2026, 17:02:53) [MSC v.1950 64 bit (AMD64)]

@zooba
zooba merged commit 6485c85 into python:mainFeb 19, 2026
66 of 67 checks passed
@chris-eibl

chris-eibl commented Feb 19, 2026

Copy link
Copy Markdown
MemberAuthor

E.g. https://github.com/python/cpython/actions/runs/22191597199/job/64180695117?pr=145005

== CPython 3.15.0a6+ (remotes/pull/145005/merge:ee4fd43, Feb 19 2026, 17:02:53) [MSC v.1950 64 bit (AMD64)]

@chris-eibl
chris-eibl deleted the windows-2025-vs2026 branch February 19, 2026 18:14
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@chris-eibl@brijkapadia
pythonGH-144679: Switch to windows-2025-vs2026 build image in GitHub …
e63f2ea
…Actions (pythonGH-145005)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@chris-eibl@ljfp
pythonGH-144679: Switch to windows-2025-vs2026 build image in GitHub …
cc82e0c
…Actions (pythonGH-145005)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@savannahostrowskisavannahostrowskisavannahostrowski approved these changes
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@webknjazwebknjazAwaiting requested review from webknjazwebknjaz is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chris-eibl@StanFromIreland@vstinner@hugovk@zooba@savannahostrowski