GH-145247: Use _PyTuple_FromPair[Steal] in Objects

[sergey-miryanov]

It is a second PR for usage of _PyTuple_FromPair[Steal] in the codebase.

• Issue: Add PyTuple_FromPair #145247

[sergey-miryanov]

Address review

[vstinner]

This change introduces a leak in the dict type (see my comment below about a leak).

[vstinner]

Ah, there are now compiler warnings, about unused variables if I understood correctly:

Objects/odictobject.c expected 0 warnings, found 1
{'file': 'Objects/odictobject.c', 'line': '1159', 'column': '29', 'message': 'unused variable ‘item’', 'option': '-Wunused-variable'}
Objects/longobject.c expected 0 warnings, found 3
{'file': 'Objects/longobject.c', 'line': '4882', 'column': '15', 'message': 'unused variable ‘z’', 'option': '-Wunused-variable'}
{'file': 'Objects/longobject.c', 'line': '6113', 'column': '27', 'message': 'unused variable ‘result’', 'option': '-Wunused-variable'}
{'file': 'Objects/longobject.c', 'line': '6356', 'column': '15', 'message': 'unused variable ‘ratio_tuple’', 'option': '-Wunused-variable'}

[sergey-miryanov]

Ah, there are now compiler warnings, about unused variables if I understood correctly:

Yeah, I fixed it. Working on left review comments.

[sergey-miryanov]

@vstinner Thanks for review! Could you please take a look?

[vstinner]

LGTM. I have have a few more coding style suggestions.

[vstinner]

Sorry, more sugestions for dictitems_xor_lock_held() which is the most complex function of this change. I propose further changes to make the code easier to follow.

[vstinner]

Thanks for all updates! I enabled auto-merge on the PR. IMO this change makes the code easier to follow/review.

[sergey-miryanov]

Thanks for review!