GH-145247: Use _PyTuple_FromPair[Steal] in Objects

Objects/codeobject.c

@@ -3052,7 +3052,7 @@ _PyCode_ConstantKey(PyObject *op)
  else if (PyBool_Check(op) || PyBytes_CheckExact(op)) {
  /* Make booleans different from integers 0 and 1.
  * Avoid BytesWarning from comparing bytes with strings. */
- key = PyTuple_Pack(2, Py_TYPE(op), op);
+ key = _PyTuple_FromPair((PyObject *)Py_TYPE(op), op);
  }
  else if (PyFloat_CheckExact(op)) {
  double d = PyFloat_AS_DOUBLE(op);
@@ -3062,7 +3062,7 @@ _PyCode_ConstantKey(PyObject *op)
  if (d == 0.0 && copysign(1.0, d) < 0.0)
  key = PyTuple_Pack(3, Py_TYPE(op), op, Py_None);
  else
- key = PyTuple_Pack(2, Py_TYPE(op), op);
+ key = _PyTuple_FromPair((PyObject *)Py_TYPE(op), op);
  }
  else if (PyComplex_CheckExact(op)) {
  Py_complex z;
@@ -3086,7 +3086,7 @@ _PyCode_ConstantKey(PyObject *op)
  key = PyTuple_Pack(3, Py_TYPE(op), op, Py_None);
  }
  else {
- key = PyTuple_Pack(2, Py_TYPE(op), op);
+ key = _PyTuple_FromPair((PyObject *)Py_TYPE(op), op);
  }
  }
  else if (PyTuple_CheckExact(op)) {
@@ -3111,7 +3111,7 @@ _PyCode_ConstantKey(PyObject *op)
  PyTuple_SET_ITEM(tuple, i, item_key);
  }
 
- key = PyTuple_Pack(2, tuple, op);
+ key = _PyTuple_FromPair(tuple, op);
  Py_DECREF(tuple);
  }
  else if (PyFrozenSet_CheckExact(op)) {
@@ -3145,7 +3145,7 @@ _PyCode_ConstantKey(PyObject *op)
  if (set == NULL)
  return NULL;
 
- key = PyTuple_Pack(2, set, op);
+ key = _PyTuple_FromPair(set, op);
  Py_DECREF(set);
  return key;
  }
@@ -3176,7 +3176,7 @@ _PyCode_ConstantKey(PyObject *op)
  goto slice_exit;
  }
 
- key = PyTuple_Pack(2, slice_key, op);
+ key = _PyTuple_FromPair(slice_key, op);
  Py_DECREF(slice_key);
  slice_exit:
  Py_XDECREF(start_key);
@@ -3190,7 +3190,7 @@ _PyCode_ConstantKey(PyObject *op)
  if (obj_id == NULL)
  return NULL;
 
- key = PyTuple_Pack(2, obj_id, op);
+ key = _PyTuple_FromPair(obj_id, op);
  Py_DECREF(obj_id);
  }
  return key;

Objects/dictobject.c

@@ -5454,7 +5454,7 @@ dictiter_new(PyDictObject *dict, PyTypeObject *itertype)
  }
  if (itertype == &PyDictIterItem_Type ||
  itertype == &PyDictRevIterItem_Type) {
- di->di_result = PyTuple_Pack(2, Py_None, Py_None);
+ di->di_result = _PyTuple_FromPairSteal(Py_None, Py_None);
  if (di->di_result == NULL) {
  Py_DECREF(di);
  return NULL;
@@ -6020,14 +6020,7 @@ dictiter_iternextitem(PyObject *self)
  _PyTuple_Recycle(result);
  }
  else {
- result = PyTuple_New(2);
- if (result == NULL) {
- Py_DECREF(key);
- Py_DECREF(value);
- return NULL;
- }
- PyTuple_SET_ITEM(result, 0, key);
- PyTuple_SET_ITEM(result, 1, value);
+ result = _PyTuple_FromPairSteal(key, value);
  }
  return result;
  }
@@ -6146,12 +6139,7 @@ dictreviter_iter_lock_held(PyDictObject *d, PyObject *self)
  _PyTuple_Recycle(result);
  }
  else {
- result = PyTuple_New(2);
- if (result == NULL) {
- return NULL;
- }
- PyTuple_SET_ITEM(result, 0, Py_NewRef(key));
- PyTuple_SET_ITEM(result, 1, Py_NewRef(value));
+ result = _PyTuple_FromPair(key, value);
  }
  return result;
  }
@@ -6644,18 +6632,22 @@ dictitems_xor_lock_held(PyObject *d1, PyObject *d2)
  else {
  Py_INCREF(val1);
  to_delete = PyObject_RichCompareBool(val1, val2, Py_EQ);
+ Py_CLEAR(val1);
  if (to_delete < 0) {
  goto error;
  }
  }
 
  if (to_delete) {
+ Py_CLEAR(val2);
  if (_PyDict_DelItem_KnownHash(temp_dict, key, hash) < 0) {
  goto error;
  }
+ Py_CLEAR(key);
  }
  else {
- PyObject *pair = PyTuple_Pack(2, key, val2);
+ PyObject *pair = _PyTuple_FromPairSteal(key, val2);
+ key = val2 = NULL;
  if (pair == NULL) {
  goto error;
  }
@@ -6665,11 +6657,7 @@ dictitems_xor_lock_held(PyObject *d1, PyObject *d2)
  }
  Py_DECREF(pair);
  }
- Py_DECREF(key);
- Py_XDECREF(val1);
- Py_DECREF(val2);
  }
- key = val1 = val2 = NULL;
 
  PyObject *remaining_pairs = PyObject_CallMethodNoArgs(
  temp_dict, &_Py_ID(items));

Objects/enumobject.c

@@ -78,7 +78,7 @@ enum_new_impl(PyTypeObject *type, PyObject *iterable, PyObject *start)
  Py_DECREF(en);
  return NULL;
  }
- en->en_result = PyTuple_Pack(2, Py_None, Py_None);
+ en->en_result = _PyTuple_FromPairSteal(Py_None, Py_None);
  if (en->en_result == NULL) {
  Py_DECREF(en);
  return NULL;
@@ -226,15 +226,7 @@ enum_next_long(enumobject *en, PyObject* next_item)
  _PyTuple_Recycle(result);
  return result;
  }
- result = PyTuple_New(2);
- if (result == NULL) {
- Py_DECREF(next_index);
- Py_DECREF(next_item);
- return NULL;
- }
- PyTuple_SET_ITEM(result, 0, next_index);
- PyTuple_SET_ITEM(result, 1, next_item);
- return result;
+ return _PyTuple_FromPairSteal(next_index, next_item);
 }
 
 static PyObject *
@@ -276,15 +268,7 @@ enum_next(PyObject *op)
  _PyTuple_Recycle(result);
  return result;
  }
- result = PyTuple_New(2);
- if (result == NULL) {
- Py_DECREF(next_index);
- Py_DECREF(next_item);
- return NULL;
- }
- PyTuple_SET_ITEM(result, 0, next_index);
- PyTuple_SET_ITEM(result, 1, next_item);
- return result;
+ return _PyTuple_FromPairSteal(next_index, next_item);
 }
 
 static PyObject *

Objects/floatobject.c

@@ -16,6 +16,7 @@
 #include "pycore_pystate.h" // _PyInterpreterState_GET()
 #include "pycore_stackref.h" // PyStackRef_AsPyObjectBorrow()
 #include "pycore_structseq.h" // _PyStructSequence_FiniBuiltin()
+#include "pycore_tuple.h" // _PyTuple_FromPair
 
 #include <float.h> // DBL_MAX
 #include <stdlib.h> // strtol()
@@ -1539,8 +1540,9 @@ float_as_integer_ratio_impl(PyObject *self)
  if (denominator == NULL)
  goto error;
  }
+ Py_DECREF(py_exponent);
 
-result_pair = PyTuple_Pack(2, numerator, denominator);
+return _PyTuple_FromPairSteal(numerator, denominator);
 
 error:
  Py_XDECREF(py_exponent);

Objects/frameobject.c

@@ -13,6 +13,7 @@
 #include "pycore_object.h" // _PyObject_GC_UNTRACK()
 #include "pycore_opcode_metadata.h" // _PyOpcode_Caches
 #include "pycore_optimizer.h" // _Py_Executors_InvalidateDependency()
+#include "pycore_tuple.h" // _PyTuple_FromPair
 #include "pycore_unicodeobject.h" // _PyUnicode_Equal()
 
 #include "frameobject.h" // PyFrameLocalsProxyObject
@@ -630,22 +631,16 @@ framelocalsproxy_items(PyObject *self, PyObject *Py_UNUSED(ignored))
  PyObject *value = framelocalsproxy_getval(frame->f_frame, co, i);
 
  if (value) {
- PyObject *pair = PyTuple_Pack(2, name, value);
+ PyObject *pair = _PyTuple_FromPairSteal(Py_NewRef(name), value);
  if (pair == NULL) {
- Py_DECREF(items);
- Py_DECREF(value);
- return NULL;
- }
-
- if (PyList_Append(items, pair) < 0) {
- Py_DECREF(items);
- Py_DECREF(pair);
- Py_DECREF(value);
- return NULL;
+ goto error;
  }
 
+ int rc = PyList_Append(items, pair);
  Py_DECREF(pair);
- Py_DECREF(value);
+ if (rc < 0) {
+ goto error;
+ }
  }
  }
 
@@ -655,23 +650,24 @@ framelocalsproxy_items(PyObject *self, PyObject *Py_UNUSED(ignored))
  PyObject *key = NULL;
  PyObject *value = NULL;
  while (PyDict_Next(frame->f_extra_locals, &j, &key, &value)) {
- PyObject *pair = PyTuple_Pack(2, key, value);
+ PyObject *pair = _PyTuple_FromPair(key, value);
  if (pair == NULL) {
- Py_DECREF(items);
- return NULL;
- }
-
- if (PyList_Append(items, pair) < 0) {
- Py_DECREF(items);
- Py_DECREF(pair);
- return NULL;
+ goto error;
  }
 
+ int rc = PyList_Append(items, pair);
  Py_DECREF(pair);
+ if (rc < 0) {
+ goto error;
+ }
  }
  }
 
  return items;
+
+error:
+ Py_DECREF(items);
+ return NULL;
 }
 
 static Py_ssize_t

Objects/listobject.c

@@ -1437,9 +1437,9 @@ list_extend_dictitems(PyListObject *self, PyDictObject *dict)
  PyObject **dest = self->ob_item + m;
  Py_ssize_t pos = 0;
  Py_ssize_t i = 0;
- PyObject *key_value[2];
- while (_PyDict_Next((PyObject *)dict, &pos, &key_value[0], &key_value[1], NULL)) {
- PyObject *item = PyTuple_FromArray(key_value, 2);
+ PyObject *key, *value;
+ while (_PyDict_Next((PyObject *)dict, &pos, &key, &value, NULL)) {
+ PyObject *item = _PyTuple_FromPair(key, value);
  if (item == NULL) {
  Py_SET_SIZE(self, m + i);
  return -1;

Objects/longobject.c

@@ -12,6 +12,7 @@
 #include "pycore_runtime.h" // _PY_NSMALLPOSINTS
 #include "pycore_stackref.h"
 #include "pycore_structseq.h" // _PyStructSequence_FiniBuiltin()
+#include "pycore_tuple.h" // _PyTuple_FromPairSteal
 #include "pycore_unicodeobject.h" // _PyUnicode_Equal()
 
 #include <float.h> // DBL_MANT_DIG
@@ -4878,23 +4879,12 @@ static PyObject *
 long_divmod(PyObject *a, PyObject *b)
 {
  PyLongObject *div, *mod;
- PyObject *z;
-
  CHECK_BINOP(a, b);
 
  if (l_divmod((PyLongObject*)a, (PyLongObject*)b, &div, &mod) < 0) {
  return NULL;
  }
- z = PyTuple_New(2);
- if (z != NULL) {
- PyTuple_SET_ITEM(z, 0, (PyObject *) div);
- PyTuple_SET_ITEM(z, 1, (PyObject *) mod);
- }
- else {
- Py_DECREF(div);
- Py_DECREF(mod);
- }
- return z;
+ return _PyTuple_FromPairSteal((PyObject *)div, (PyObject *)mod);
 }
 
 
@@ -6118,7 +6108,7 @@ PyObject *
 _PyLong_DivmodNear(PyObject *a, PyObject *b)
 {
  PyLongObject *quo = NULL, *rem = NULL;
- PyObject *twice_rem, *result, *temp;
+ PyObject *twice_rem, *temp;
  int quo_is_odd, quo_is_neg;
  Py_ssize_t cmp;
 
@@ -6184,14 +6174,7 @@ _PyLong_DivmodNear(PyObject *a, PyObject *b)
  goto error;
  }
 
- result = PyTuple_New(2);
- if (result == NULL)
- goto error;
-
- /* PyTuple_SET_ITEM steals references */
- PyTuple_SET_ITEM(result, 0, (PyObject *)quo);
- PyTuple_SET_ITEM(result, 1, (PyObject *)rem);
- return result;
+ return _PyTuple_FromPairSteal((PyObject *)quo, (PyObject *)rem);
 
  error:
  Py_XDECREF(quo);
@@ -6368,14 +6351,11 @@ static PyObject *
 int_as_integer_ratio_impl(PyObject *self)
 /*[clinic end generated code: output=e60803ae1cc8621a input=384ff1766634bec2]*/
 {
- PyObject *ratio_tuple;
  PyObject *numerator = long_long(self);
  if (numerator == NULL) {
  return NULL;
  }
- ratio_tuple = PyTuple_Pack(2, numerator, _PyLong_GetOne());
- Py_DECREF(numerator);
- return ratio_tuple;
+ return _PyTuple_FromPairSteal(numerator, _PyLong_GetOne());
 }
 
 /*[clinic input]