Skip to content

gh-145866: Convert CALL_INTRINSIC_1 to leave its inputs on the stack to be cleaned up by _POP_TOP. - #145964

Merged
markshannon merged 4 commits into
python:mainfrom
Sacul0457:Optimize_CALL_INTRINSIC_1
Mar 16, 2026
Merged

gh-145866: Convert CALL_INTRINSIC_1 to leave its inputs on the stack to be cleaned up by _POP_TOP.#145964
markshannon merged 4 commits into
python:mainfrom
Sacul0457:Optimize_CALL_INTRINSIC_1

Conversation

@Sacul0457

@Sacul0457Sacul0457 commented Mar 15, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Mar 15, 2026
Open
Fidget-Spinner
Fidget-Spinner approved these changes Mar 15, 2026
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

corona10
corona10 reviewed Mar 15, 2026
View reviewed changes
Comment threadMisc/NEWS.d/next/Core_and_Builtins/2026-03-15-04-27-17.gh-issue-145866.1oBN2p.rst Outdated
@@ -0,0 +1 @@
Convert ``CALL_INTRINSIC_1`` to leave its inputs on the stack to be cleaned up by ``_POP_TOP``.

@corona10corona10Mar 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: NEWS.d is not needed until this is affected to end-users.

@Sacul0457Sacul0457Mar 15, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted, thx

Fidget-Spinner
Fidget-Spinner requested changes Mar 15, 2026
View reviewed changes
Comment threadPython/bytecodes.c Outdated
Comment on lines +1252 to +1256
v = value;
DEAD(value);
if (res_o == NULL) {
ERROR_NO_POP();
}

@Fidget-SpinnerFidget-SpinnerMar 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I made a mistake, I think v should only transfer ownership after the error branch.

@bedevere-app

bedevere-appBot commented Mar 15, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Sacul0457

Sacul0457 commented Mar 15, 2026

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app

bedevere-appBot commented Mar 15, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner: please review the changes made to this pull request.

markshannon
markshannon approved these changes Mar 16, 2026
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks

@markshannon
markshannon merged commit 37121ef into python:mainMar 16, 2026
78 of 81 checks passed
@Sacul0457
Sacul0457 deleted the Optimize_CALL_INTRINSIC_1 branch March 19, 2026 13:22
@KevinH15291KevinH15291 mentioned this pull request Mar 21, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Sacul0457@ljfp
pythongh-145866: ConvertCALL_INTRINSIC_1to leave its inputs on th…
0ca6a5c
…e stack to be cleaned up by `_POP_TOP`. (pythonGH-145964)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 left review comments
@markshannonmarkshannonmarkshannon approved these changes
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sacul0457@corona10@markshannon@Fidget-Spinner@savannahostrowski