Uh oh!
There was an error while loading. Please reload this page.
gh-145866: Convert _CALL_INTRINSIC_2 to leave its inputs on the stack to be cleaned up by _POP_TOP - #146262
Conversation
All commit authors signed the Contributor License Agreement. |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
KevinH15291
commented
Mar 21, 2026
This is my first CPython PR and I'm not very experienced. This PR largely just copies the style of the other PRs in #145866 and #134584, mainly #145964. I'm not sure if self.assertLessEqual(count_ops(ex, "_POP_TOP"), 4)in my test is completely correct, as well as my testfunc deftestfunc(n):
x=0for_inrange(n):
deftest_testfunc[T](n):
passreturnxI'm also not 100% sure if regenerated the opcode metadata stuff correctly. Otherwise I believe the PR should be good. |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Nice, this looks really good, thanks for doing this!
| uops = get_opnames(ex) | ||
| self.assertIn("_CALL_INTRINSIC_2", uops) | ||
| self.assertEqual(count_ops(ex, "_POP_TOP_NOP"), 2) |
There was a problem hiding this comment.
GreaterEqual might be better. Also did you count how many POP_TOP_NOPs this produces? You can print the trace logs by compiling with the tier 2 interpreter (--enable-experimental-jit=interpreter) and passing the env var PYTHON_LLTRACE=2.
There was a problem hiding this comment.
Well honestly, I got lucky; I doubled the numbers used in the test for _CALL_INTRINSIC_1. Later I did verify this, by uh, modifying the end of the test function to print uops, and looking at the printed output, as I was not aware of PYTHON_LLTRACE=2 yet.
There was a problem hiding this comment.
Ok cool, thanks for verifying. We want to use GreaterEqual here in case we introduce more optimizations in the future, and we don't want to cause this to break.
Fidget-Spinner
commented
Mar 24, 2026
@KevinH15291 sorry could you please pull in main and regenerate the files again? Thanks! |
_CALL_INTRINSIC_2_CALL_INTRINSIC_2 to leave its inputs on the stack to be cleaned up by _POP_TOPUh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner
commented
Mar 26, 2026
@KevinH15291 thank you for your contribution to CPython, and welcome! |
…he stack to be cleaned up by `_POP_TOP` (pythonGH-146262)
…he stack to be cleaned up by `_POP_TOP` (pythonGH-146262)
_POP_TOP#145866