Skip to content

gh-146376: Reduce timeout in Emscripten workflow - #146378

Merged
vstinner merged 2 commits into
python:mainfrom
hoodmane:emscripten-reduce-ci-timeout
Mar 30, 2026
Merged

gh-146376: Reduce timeout in Emscripten workflow#146378
vstinner merged 2 commits into
python:mainfrom
hoodmane:emscripten-reduce-ci-timeout

Conversation

@hoodmane

@hoodmanehoodmane commented Mar 24, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Mar 24, 2026
Closed
@hoodmanehoodmane mentioned this pull request Mar 24, 2026
Merged
webknjaz
webknjaz approved these changes Mar 24, 2026
View reviewed changes

@webknjazwebknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner

vstinner commented Mar 25, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Does Emscripten supports faulthandler.dump_traceback_later(timeout, exit=True)? If yes, I would prefer to pass a --timeout=seconds option to the python -m test (...) command (which uses dump_traceback_later()), rather than reducing the CI overall timeout.

@webknjaz

webknjaz commented Mar 25, 2026

Copy link
Copy Markdown
Member

@vstinner if that's possible, I'd recommend both timeouts (with different values). Also, this sounds like something to do in other jobs too.

hugovk
hugovk reviewed Mar 29, 2026
View reviewed changes
Comment thread.github/workflows/reusable-emscripten.yml Outdated
Comment on lines +13 to +26
# It seems to take about 20 minutes without the cache, broken down as follows:
# (All times recorded from one run chosen arbitrarily.)
#
# 0.5 install Emscripten (skipped by cache)
# 1.0 configure & build native python
# 0.5 build dependencies (skipped by cache)
# 3.0 configure Emscripten Python
# 1.5 build Emscripten Python
# 0.7 build Emscripten ports (skipped by cache)
# 14.0 Test
#
# So if we add time for a rerun of the entire test suite, we get to 34
# minutes. Adding an extra 5% gets us to 36.
timeout-minutes: 36

@hugovkhugovkMar 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need all the calculations here. It can be in the PR description.

And let's round the number. If the time starts being too short, we'll just bump it up a bit.

Suggested change
# It seems to take about 20 minutes without the cache, broken down as follows:
# (All times recorded from one run chosen arbitrarily.)
#
# 0.5 install Emscripten (skipped by cache)
# 1.0 configure & build native python
# 0.5 build dependencies (skipped by cache)
# 3.0 configure Emscripten Python
# 1.5 build Emscripten Python
# 0.7 build Emscripten ports (skipped by cache)
# 14.0 Test
#
# So if we add time for a rerun of the entire test suite, we get to 34
# minutes. Adding an extra 5% gets us to 36.
timeout-minutes: 36
timeout-minutes: 40

@vstinner

vstinner commented Mar 30, 2026

Copy link
Copy Markdown
Member

@hoodmane: Can you change the timeout to 40 minutes and remove the long comment, as suggested by @hugovk?

vstinner
vstinner approved these changes Mar 30, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner enabled auto-merge (squash) March 30, 2026 20:20
@vstinner
vstinner merged commit 70d1b08 into python:mainMar 30, 2026
31 checks passed
@hugovkhugovk added the needs backport to 3.14 bugs and security fixes label Mar 30, 2026
@miss-islington-app

miss-islington-appBot commented Mar 30, 2026

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Mar 30, 2026

Copy link
Copy Markdown

GH-146645 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 30, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2026
@hoodmane@miss-islington
pythongh-146376: Reduce timeout in Emscripten GHA workflow (pythonGH-…
b5cd4a0
…146378)
(cherry picked from commit 70d1b08)
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
hugovk pushed a commit that referenced this pull request Mar 30, 2026
@miss-islington@hoodmane
[3.14]gh-146376: Reduce timeout in Emscripten GHA workflow (GH-146378)…
99f333d
… (#146645)
gh-146376: Reduce timeout in Emscripten GHA workflow (GH-146378)
(cherry picked from commit 70d1b08)
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 31, 2026
@maurycy
Merge branch 'main' into tachyon-ndjson-kolektor
9836ffa
* main:
pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
pythongh-146238: Support half-floats in the array module (python#146242)
pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)
@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@hoodmane@clin1234
pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#14…
d768991
…6378)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hoodmane@ljfp
pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#14…
0345f33
…6378)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments
@vstinnervstinnervstinner approved these changes
@webknjazwebknjazwebknjaz approved these changes
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

OS-emscriptenskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoodmane@vstinner@webknjaz@hugovk