Skip to content

gh-146615: Fix format specifiers in Objects/ directory - #146620

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
sunmy2019:gh-146615-4
Mar 31, 2026
Merged

gh-146615: Fix format specifiers in Objects/ directory#146620
serhiy-storchaka merged 2 commits into
python:mainfrom
sunmy2019:gh-146615-4

Conversation

@sunmy2019

@sunmy2019sunmy2019 commented Mar 30, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 30, 2026
Closed
@sunmy2019sunmy2019 mentioned this pull request Mar 30, 2026
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Mar 30, 2026
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

picnixz
picnixz reviewed Mar 30, 2026
View reviewed changes
Comment threadObjects/descrobject.c Outdated
@picnixz

picnixz commented Mar 30, 2026

Copy link
Copy Markdown
Member

I would suggest that we merge the various PRs without a NEWS entry and that we create one new entry for many PRs and add a commit message with links to those PRs.

This was referenced Mar 30, 2026
Merged
Merged
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Mar 30, 2026
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review March 30, 2026 17:42
@serhiy-storchaka
serhiy-storchaka merged commit bbf7fb2 into python:mainMar 31, 2026
61 checks passed
@miss-islington-app

miss-islington-appBot commented Mar 31, 2026

Copy link
Copy Markdown

Thanks @sunmy2019 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 31, 2026
@sunmy2019@miss-islington
pythongh-146615: Fix format specifiers in Objects/ directory (pythonG…
4b7067f
…H-146620)
(cherry picked from commit bbf7fb2)
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
@miss-islington-app

miss-islington-appBot commented Mar 31, 2026

Copy link
Copy Markdown

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bbf7fb2c15a1dc9a54d10937c3d0831b0968257d 3.13

@bedevere-app

bedevere-appBot commented Mar 31, 2026

Copy link
Copy Markdown

GH-146651 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 31, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
@sunmy2019@serhiy-storchaka
[3.13]pythongh-146615: Fix format specifiers in Objects/ directory (p…
982a139
…ythonGH-146620)
(cherry picked from commit bbf7fb2)
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Mar 31, 2026

Copy link
Copy Markdown

GH-146655 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Mar 31, 2026
@serhiy-storchakaserhiy-storchaka removed their assignment Mar 31, 2026
serhiy-storchaka added a commit that referenced this pull request Mar 31, 2026
@serhiy-storchaka@sunmy2019
[3.13]gh-146615: Fix format specifiers in Objects/ directory (GH-146620
499df18
) (GH-146655)
(cherry picked from commit bbf7fb2)
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Mar 31, 2026
@miss-islington@sunmy2019
[3.14]gh-146615: Fix format specifiers in Objects/ directory (GH-146620
e5ec90e
) (GH-146651)
(cherry picked from commit bbf7fb2)
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 31, 2026
@maurycy
Merge branch 'main' into tachyon-ndjson-kolektor
9836ffa
* main:
pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
pythongh-146238: Support half-floats in the array module (python#146242)
pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)
@bedevere-app

bedevere-appBot commented Mar 31, 2026

Copy link
Copy Markdown

GH-147705 is a backport of this pull request to the 3.13 branch.

vstinner pushed a commit that referenced this pull request Apr 1, 2026
@sunmy2019
[3.13]gh-146615: Fix format specifiers in Objects/ directory (GH-146620
c0eae2a
) (#147705)
* Fix format specifiers in vgetargskeywordsfast_impl for improved error messages.
* Fix f-string syntax error message in tok_get_normal_mode.
@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@sunmy2019@clin1234
pythongh-146615: Fix format specifiers in Objects/ directory (pythonG…
574c009
…H-146620)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@sunmy2019@ljfp
pythongh-146615: Fix format specifiers in Objects/ directory (pythonG…
07c785e
…H-146620)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunmy2019@picnixz@serhiy-storchaka