Skip to content

bpo-40939: Generate keyword.py using pegen - #20800

Merged
pablogsal merged 3 commits into
python:masterfrom
lysnikolaou:keywordgen
Jun 11, 2020
Merged

bpo-40939: Generate keyword.py using pegen#20800
pablogsal merged 3 commits into
python:masterfrom
lysnikolaou:keywordgen

Conversation

@lysnikolaou

@lysnikolaoulysnikolaou commented Jun 11, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal
pablogsal requested changes Jun 11, 2020
View reviewed changes
Comment threadLib/keyword.py
@bedevere-bot

bedevere-bot commented Jun 11, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pablogsal

pablogsal commented Jun 11, 2020

Copy link
Copy Markdown
Member

Can you also update the Windows regen file? (PCbuild/regen.vcxproj)

@pablogsalpablogsal mentioned this pull request Jun 11, 2020
Merged
@lysnikolaou
lysnikolaou requested a review from a team as a code ownerJune 11, 2020 11:39
@pablogsal
pablogsal merged commit 9727694 into python:masterJun 11, 2020
@miss-islington

miss-islington commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal

pablogsal commented Jun 11, 2020

Copy link
Copy Markdown
Member

Thanks for the PR, @lysnikolaou! 🚀

@bedevere-bot

bedevere-bot commented Jun 11, 2020

Copy link
Copy Markdown

GH-20801 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 11, 2020
@miss-islington@lysnikolaou
bpo-40939: Generate keyword.py using the new parser (GH-20800)
961edf7
(cherry picked from commit 9727694)
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@lysnikolaou
lysnikolaou deleted the keywordgen branch June 11, 2020 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lysnikolaou@bedevere-bot@pablogsal@miss-islington@the-knights-who-say-ni