Skip to content

gh-79097: Add support for aggregate window functions in sqlite3 - #20903

Merged
JelleZijlstra merged 57 commits into
python:mainfrom
erlend-aasland:fix-issue-34916
Apr 12, 2022
Merged

gh-79097: Add support for aggregate window functions in sqlite3#20903
JelleZijlstra merged 57 commits into
python:mainfrom
erlend-aasland:fix-issue-34916

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#79097

@erlend-aasland

erlend-aasland commented Nov 6, 2020

Copy link
Copy Markdown
ContributorAuthor

Rebased onto master and upgraded with Py_NewRef and intermingled declarations.

@erlend-aasland
erlend-aasland marked this pull request as draft November 17, 2020 22:28
@erlend-aasland

erlend-aasland commented Nov 17, 2020

Copy link
Copy Markdown
ContributorAuthor

On hold until #23341 is merged

@erlend-aasland
erlend-aaslandforce-pushed the fix-issue-34916 branch 2 times, most recently from f39fc9f to a36a1a5CompareDecember 28, 2020 11:58
@erlend-aasland
erlend-aaslandforce-pushed the fix-issue-34916 branch 10 times, most recently from 9c27690 to b91947dCompareMarch 10, 2021 13:02
@erlend-aasland
erlend-aasland marked this pull request as ready for review March 10, 2021 13:33
@erlend-aaslanderlend-aasland mentioned this pull request Mar 10, 2021
Closed
@erlend-aasland
erlend-aaslandforce-pushed the fix-issue-34916 branch 2 times, most recently from 5f17f41 to f1459edCompareApril 18, 2021 22:09
@erlend-aasland
erlend-aaslandforce-pushed the fix-issue-34916 branch 2 times, most recently from 799bcf6 to 3f052a6CompareApril 23, 2021 09:21
Erlend E. Aasland added 3 commits April 23, 2021 11:24
Erlend E. Aasland
Add support for sqlite3 aggregate window functions
bbef5a4
See https://docs.python.org/3/library/exceptions.html#NotImplementedError:
It should not be used to indicate that an operator or method is not
meant to be supported at all – in that case either leave the operator /
method undefined or, if a subclass, set it to None.
Erlend E. Aasland
Add NEWS entry
93bfb30
Erlend E. Aasland
Add What's New
7dfeb13
@erlend-aasland

erlend-aasland commented Apr 23, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@berkerpeksag Any chance of getting this in before the feature freeze early in the 3.11 dev phase?

@erlend-aaslanderlend-aasland changed the title bpo-34916: Add support for aggregate window functions in sqlite3bpo-79097: Add support for aggregate window functions in sqlite3Apr 10, 2022
@erlend-aaslanderlend-aasland changed the title bpo-79097: Add support for aggregate window functions in sqlite3gh-79097: Add support for aggregate window functions in sqlite3Apr 10, 2022
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 10, 2022 22:14
@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@bedevere-bot

bedevere-bot commented Apr 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@erlend-aaslanderlend-aasland added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section extension-modules C modules in the Modules dir labels Apr 10, 2022
@bedevere-bot

bedevere-bot commented Apr 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@erlend-aasland

erlend-aasland commented Apr 11, 2022

Copy link
Copy Markdown
ContributorAuthor

@JelleZijlstra, would you like to review this?

FYI, the two buildbot failures look unrelated.

@JelleZijlstra
JelleZijlstra self-requested a review April 11, 2022 16:17
JelleZijlstra
JelleZijlstra reviewed Apr 11, 2022
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one requested improvement in the tests.

Let me know if there's other changes you'd like to get in in time for 3.11.

Comment threadLib/test/test_sqlite3/test_userfunctions.py
@JelleZijlstraJelleZijlstra self-assigned this Apr 11, 2022
@erlend-aasland

erlend-aasland commented Apr 11, 2022

Copy link
Copy Markdown
ContributorAuthor

Let me know if there's other changes you'd like to get in in time for 3.11.

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

@JelleZijlstra

JelleZijlstra commented Apr 11, 2022

Copy link
Copy Markdown
Member

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

Sounds good, ping me when you're ready.

@JelleZijlstra
JelleZijlstra merged commit 9ebcece into python:mainApr 12, 2022
@BigStoneBigStonemannequin mentioned this pull request Apr 10, 2022
Closed
@erlend-aasland

erlend-aasland commented Apr 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks, @JelleZijlstra! Much appreciated.

@erlend-aasland
erlend-aasland deleted the fix-issue-34916 branch April 12, 2022 10:35
@JelleZijlstraJelleZijlstra mentioned this pull request Apr 15, 2022
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 15, 2022
@JelleZijlstra
sqlite3: add 3.11 additions
0ba23bb
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
srittau pushed a commit to python/typeshed that referenced this pull request Apr 16, 2022
@JelleZijlstra
sqlite3: add 3.11 additions (#7625)
d802e65
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

@JelleZijlstraJelleZijlstra

Labels

extension-modulesC modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add create_window_function() to sqlite3.Connection

5 participants

@erlend-aasland@bedevere-bot@JelleZijlstra@kumaraditya303@the-knights-who-say-ni