Skip to content

bpo-45243: Add support for setting/getting sqlite3 connection limits - #28463

Merged
pablogsal merged 16 commits into
python:mainfrom
erlend-aasland:sqlite-limits
Nov 1, 2021
Merged

bpo-45243: Add support for setting/getting sqlite3 connection limits#28463
pablogsal merged 16 commits into
python:mainfrom
erlend-aasland:sqlite-limits

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Sep 19, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Oct 7, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thinking about this, I wonder if connection limits are better implemented as attributes:

importsqlite3cx=sqlite3.connect(":memory:")
lim=cx.SQLITE_LIMIT_LENGTHcx.SQLITE_LIMIT_LENGTH=100# instead oflim=cx.getlimit(sqlite3.SQLITE_LIMIT_LENGTH)
cx.setlimit(sqlite3.SQLITE_LIMIT_LENGTH, 100)

I added GH-28790 as an alternative implementation.

@erlend-aaslanderlend-aasland mentioned this pull request Oct 7, 2021
Closed
serhiy-storchaka
serhiy-storchaka reviewed Oct 7, 2021
View reviewed changes
Comment threadModules/_sqlite/connection.c Outdated
Comment threadModules/_sqlite/connection.c
Comment threadModules/_sqlite/connection.c Outdated
Comment threadModules/_sqlite/module.c
@erlend-aasland

erlend-aasland commented Oct 8, 2021

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka I changed the argument spec:

  • setlimit(limit, value, /) => setlimit(category, limit, /)
  • getlimit(limit, /) => getlimit(category, /)

I believe this is clearer and more aligned with the SQLite documentation.

@erlend-aasland

erlend-aasland commented Oct 8, 2021

Copy link
Copy Markdown
ContributorAuthor

PTAL, @serhiy-storchaka.

@erlend-aasland

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka I believe all comments have been resolved. Would you like to take another look at this PR?

@erlend-aaslanderlend-aasland mentioned this pull request Oct 29, 2021
Merged
@erlend-aasland

erlend-aasland commented Nov 1, 2021

Copy link
Copy Markdown
ContributorAuthor

@pablogsal would you mind taking a look at this? I believe I've addressed all of Serhiy's comments.

pablogsal
pablogsal approved these changes Nov 1, 2021
View reviewed changes

@pablogsalpablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
pablogsal merged commit b6b38a8 into python:mainNov 1, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-limits branch November 1, 2021 22:53
@JelleZijlstraJelleZijlstra mentioned this pull request Apr 15, 2022
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 15, 2022
@JelleZijlstra
sqlite3: add 3.11 additions
0ba23bb
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
srittau pushed a commit to python/typeshed that referenced this pull request Apr 16, 2022
@JelleZijlstra
sqlite3: add 3.11 additions (#7625)
d802e65
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
@erlend-aaslanderlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@serhiy-storchaka@pablogsal@the-knights-who-say-ni@bedevere-bot