Uh oh!
There was an error while loading. Please reload this page.
bpo-39010: Fix errors logged on proactor loop restart - #22017
Merged
Conversation
Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop.
bdarnell
commented
Aug 30, 2020
ContributorAuthor
The failing CI test ( |
1st1
commented
Aug 31, 2020
Member
LGTM. Ben, should this be backported to 3.8/3.9? |
1st1
approved these changes
Aug 31, 2020
bdarnell
commented
Aug 31, 2020
ContributorAuthor
Yes, this should be backported to 3.8/3.9. I haven't tested with those branches but the bug is definitely present in 3.8 (the bug is probably older but it was revealed when the proactor event loops became the default in 3.8) and I don't see any changes since then in the relevant parts of the code. |
miss-islington
commented
Aug 31, 2020
Contributor
bedevere-bot
commented
Aug 31, 2020
@1st1: Please replace |
1st1
commented
Aug 31, 2020
Member
Thanks, Ben! |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2020
Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop. (cherry picked from commit ea5a636) Co-authored-by: Ben Darnell <ben@bendarnell.com>
bedevere-bot
commented
Aug 31, 2020
GH-22034 is a backport of this pull request to the 3.9 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2020
Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop. (cherry picked from commit ea5a636) Co-authored-by: Ben Darnell <ben@bendarnell.com>
bedevere-bot
commented
Aug 31, 2020
GH-22035 is a backport of this pull request to the 3.8 branch. |
bdarnell added a commit
to bdarnell/cpython
that referenced
this pull request
Sep 2, 2020
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017
1st1 pushed a commit
that referenced
this pull request
Sep 3, 2020
1st1 pushed a commit
that referenced
this pull request
Sep 3, 2020
) Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop. (cherry picked from commit ea5a636) Co-authored-by: Ben Darnell <ben@bendarnell.com> Co-authored-by: Ben Darnell <ben@bendarnell.com>
1st1 pushed a commit
that referenced
this pull request
Sep 3, 2020
) Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop. (cherry picked from commit ea5a636) Co-authored-by: Ben Darnell <ben@bendarnell.com> Co-authored-by: Ben Darnell <ben@bendarnell.com>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <ben@bendarnell.com>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <ben@bendarnell.com>
bedevere-bot
commented
Sep 3, 2020
|
bedevere-bot
commented
Sep 3, 2020
|
bedevere-bot
commented
Sep 3, 2020
|
1st1 pushed a commit
that referenced
this pull request
Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to GH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <ben@bendarnell.com> Co-authored-by: Ben Darnell <ben@bendarnell.com>
1st1 pushed a commit
that referenced
this pull request
Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to GH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <ben@bendarnell.com> Co-authored-by: Ben Darnell <ben@bendarnell.com>
bedevere-bot
commented
Sep 3, 2020
|
bdarnell
commented
Sep 4, 2020
ContributorAuthor
The buildbot failures here appear to be the issue fixed in follow-up PR GH-22066 |
jigripokhri
commented
Oct 14, 2020
thank you senpai! |
xzy3 pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop.
xzy3 pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
https://bugs.python.org/issue39010