Skip to content

bpo-1635741 port _lsprof to multi-phase init (PEP 489) - #22220

Merged
vstinner merged 3 commits into
python:masterfrom
koubaa:bpo-1635741-lsprof
Sep 23, 2020
Merged

bpo-1635741 port _lsprof to multi-phase init (PEP 489)#22220
vstinner merged 3 commits into
python:masterfrom
koubaa:bpo-1635741-lsprof

Conversation

@koubaa

@koubaakoubaa commented Sep 12, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@koubaa

koubaa commented Sep 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner@corona10@shihai1991 please review

@shihai1991

shihai1991 commented Sep 13, 2020•
edited
Loading

Copy link
Copy Markdown
Member

compile warning: ‘getstats_doc’ defined but not used [-Wunused-const-variable=
those code should be removed?

@koubaa

koubaa commented Sep 13, 2020

Copy link
Copy Markdown
ContributorAuthor

compile warning: ‘getstats_doc’ defined but not used [-Wunused-const-variable=
those code should be removed?

Oops, I meant to remove that!

vstinner
vstinner reviewed Sep 14, 2020
View reviewed changes
Comment threadModules/_lsprof.c Outdated
@koubaakoubaa mentioned this pull request Sep 14, 2020
Merged
vstinner
vstinner approved these changes Sep 22, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have some coding style requests.

Comment threadModules/_lsprof.c Outdated
static PyStructSequence_Desc profiler_entry_desc = {
"_lsprof.profiler_entry", /* name */
NULL, /* doc */
"", /* doc */

@vstinnervstinnerSep 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO PyType_FromSpec() should accept tp_doc=NULL, I created: https://bugs.python.org/issue41832

I don't ask you to change your PR, "" vs NULL can be changed again later.

Comment threadModules/_lsprof.c Outdated
Comment threadModules/_lsprof.c Outdated
Comment threadModules/_lsprof.c Outdated
vstinner
vstinner approved these changes Sep 23, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, the new code is easier to read!

Comment threadModules/_lsprof.c
.name = "_lsprof.profiler_entry",
.doc = "",
.fields = profiler_entry_fields,
.n_in_sequence = 6

@vstinnervstinnerSep 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it's way easier to read than the old format, thanks!

Comment threadModules/_lsprof.c
if (PyModule_AddType(module, state->stats_subentry_type) < 0) {
return -1;
}

@vstinnervstinnerSep 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the new code is more regular (create type, add type, create type, add type, ...) and so easier to read!

@vstinner
vstinner merged commit 83de110 into python:masterSep 23, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 24, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_39337_new_3
e29ec44
* origin/master: (27 commits)
bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)
bpo-41833: threading.Thread now uses the target name (pythonGH-22357)
bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)
bpo-33822: Update IDLE section of What's New 3.8 (pythonGH-22383)
bpo-41844: Add IDLE section to What's New 3.9 (GN-22382)
bpo-41841: Prepare IDLE News for 3.10 (pythonGH-22379)
bpo-37779 : Add information about the overriding behavior of ConfigParser.read (pythonGH-15177)
bpo-40170: Use inline _PyType_HasFeature() function (pythonGH-22375)
bpo-40941: Fix stackdepth compiler warnings (pythonGH-22377)
bpo-40941: Fix fold_tuple_on_constants() compiler warnings (pythonGH-22378)
bpo-40521: Fix PyUnicode_InternInPlace() (pythonGH-22376)
bpo-41834: Remove _Py_CheckRecursionLimit variable (pythonGH-22359)
bpo-1635741, unicodedata: add ucd_type parameter to UCD_Check() macro (pythonGH-22328)
bpo-1635741: Port _lsprof extension to multi-phase init (PEP 489) (pythonGH-22220)
bpo-41513: Improve order of adding fractional values. Improve variable names. (pythonGH-22368)
bpo-41816: `StrEnum.__str__` is `str.__str__` (pythonGH-22362)
bpo-35764: Rewrite the IDLE Calltips doc section (pythonGH-22363)
bpo-41810: Reintroduce `types.EllipsisType`, `.NoneType` & `.NotImplementedType` (pythonGH-22336)
bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (python#21956)
...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa@xzy3-cdc
bpo-1635741: Port _lsprof extension to multi-phase init (PEP 489) (py…
499db01
…thonGH-22220)
@shihai1991shihai1991 mentioned this pull request Nov 3, 2020
Merged
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@koubaa@shihai1991@vstinner@the-knights-who-say-ni@bedevere-bot