Skip to content

bpo-1635741: convert an _lsprof method to argument clinic - #22240

Merged
vstinner merged 2 commits into
python:masterfrom
koubaa:bpo-1635741-lsprof-clinic
Sep 21, 2020
Merged

bpo-1635741: convert an _lsprof method to argument clinic#22240
vstinner merged 2 commits into
python:masterfrom
koubaa:bpo-1635741-lsprof-clinic

Conversation

@koubaa

@koubaakoubaa commented Sep 14, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@koubaa

koubaa commented Sep 14, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner Please review, this will be the first stage from #22220

vstinner
vstinner reviewed Sep 15, 2020
View reviewed changes
Comment threadModules/_lsprof.c Outdated
Comment threadModules/_lsprof.c Outdated
vstinner
vstinner approved these changes Sep 21, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please remove the NEWS entry.

Comment threadMisc/NEWS.d/next/Core and Builtins/2020-09-14-09-15-59.bpo-1635741.UnXTND.rst Outdated

@vstinnervstinnerSep 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the NEWS entry, it's not worth it.

@koubaakoubaaSep 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner done

Comment threadModules/_lsprof.c Outdated
@koubaa
koubaaforce-pushed the bpo-1635741-lsprof-clinic branch from bdd6c25 to c32f5b7CompareSeptember 21, 2020 12:03
@vstinner
vstinner merged commit 1b328ea into python:masterSep 21, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa@xzy3-cdc
bpo-1635741: Convert an _lsprof method to argument clinic (pythonGH-2…
edd5dee
…2240)
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koubaa@vstinner@the-knights-who-say-ni@bedevere-bot