Uh oh!
There was an error while loading. Please reload this page.
bpo-41916: allow cross-compiled python to have -pthread set for CXX - #22525
Conversation
virtuald
commented
Oct 6, 2020
Some testing indicates that this worked without issues. Given that the tests all seem to pass on CI, I think this is good to go. |
virtuald
commented
Oct 24, 2020
I have confirmed that this does fix the issues I was running into, and my cross compiled packages seem to be fine. |
virtuald
commented
Mar 4, 2022
I've been using it to build python 3.9.x and more recently python 3.10.x without any issues. |
FFY00
commented
Mar 4, 2022
Perhaps, just add a news item to make it quicker to merge. I think the code is good, it is just missing a news entry. |
kumaraditya303
commented
Mar 4, 2022
You can use https://blurb-it.herokuapp.com/ to add a news fragment. |
6ff346a to
0fdc88dComparejaraco
commented
Apr 4, 2022
I'm afraid I don't have a lot of experience with this aspect of CPython. Perhaps @ambv could review or suggest a reviewer? |
FWIW, I've been using the patch to cross-compile python for use in CI since I've made the patch. |
0fdc88d to
77af732Comparevirtuald
commented
Oct 14, 2022
Rebased on main; integrated changes that were made in #29485 |
virtuald
commented
Oct 14, 2022
@tiran seems to make a lot of changes to configure.ac, perhaps they might be a better reviewer for this? |
When cross-compiling, the compile/run test for -pthread always fails so -pthread will never be automatically set without an override from the cache. ac_cv_pthread can already be overridden, so do the same thing for ac_cv_cxx_thread.
77af732 to
fefd3d2Compare@tiran, do have time to have a quick look at this PR? Thanks! |
ericsnowcurrently
commented
Jan 5, 2023
IIRC, @gpshead has some interest in cross-compilation and @erlend-aasland has experience with the configure script. |
When cross-compiling, the compile/run test for -pthread always fails so -pthread will never be automatically set without an override from the cache. ac_cv_pthread can already be overridden, so do the same thing for ac_cv_cxx_thread.
I've validated that my cross-compiled python has the variables set now when configured via:
I now get as expected:
I haven't yet checked to see if it all works quite yet, will do later today.
https://bugs.python.org/issue41916