Skip to content

bpo-45723: Improve and simplify more configure.ac checks (GH-29485) - #29485

Merged
tiran merged 6 commits into
python:mainfrom
erlend-aasland:ac-more-stuff
Nov 10, 2021
Merged

bpo-45723: Improve and simplify more configure.ac checks (GH-29485)#29485
tiran merged 6 commits into
python:mainfrom
erlend-aasland:ac-more-stuff

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Nov 9, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Cache checking of -Wl,--no-as-needed
  • Make PY_CHECK_CC_WARNING more efficient
  • Consolidate AC_MSG_CHECKING and AC_CACHE_VAL

https://bugs.python.org/issue45723

@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 9, 2021
@bedevere-bot

bedevere-bot commented Nov 9, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 79b97e0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 9, 2021
tiran
tiran approved these changes Nov 9, 2021
View reviewed changes

@tirantiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll do another test before I merge the PR.

@erlend-aasland

erlend-aasland commented Nov 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Looks good to me. I'll do another test before I merge the PR.

Great, thanks!

@tirantiran changed the title bpo-45723: Improve and simplify more configure.ac checksbpo-45723: Improve and simplify more configure.ac checks (GH-29485)Nov 10, 2021
@tiran
tiran merged commit 76d14fa into python:mainNov 10, 2021
@erlend-aasland
erlend-aasland deleted the ac-more-stuff branch November 10, 2021 15:44
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland@remykarem
bpo-45723: Improve and simplify more configure.ac checks (pythonGH-29485
669fb41
)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Erlend Egeberg Aasland@remykarem
bpo-45723: Improve and simplify more configure.ac checks (pythonGH-29485
c4ffd3c
)
@tirantiran mentioned this pull request Apr 22, 2022
Closed
@virtualdvirtuald mentioned this pull request Oct 14, 2022
Merged
@eli-schwartzeli-schwartz mentioned this pull request Jun 19, 2024
Closed
@allsey87allsey87 mentioned this pull request Jun 21, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirantirantiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@tiran@the-knights-who-say-ni