Skip to content

bpo-42264: Deprecate sqlite3.OptimizedUnicode - #23163

Merged
serhiy-storchaka merged 11 commits into
python:masterfrom
erlend-aasland:bpo-42264
Nov 17, 2020
Merged

bpo-42264: Deprecate sqlite3.OptimizedUnicode#23163
serhiy-storchaka merged 11 commits into
python:masterfrom
erlend-aasland:bpo-42264

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Nov 5, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#86430

@erlend-aaslanderlend-aasland changed the title bpo-42264: Deprecate OptimizedUnicodebpo-42264: Deprecate sqlite3.OptimizedUnicodeNov 5, 2020
serhiy-storchaka
serhiy-storchaka requested changes Nov 5, 2020
View reviewed changes
Comment threadLib/sqlite3/deprecated.py Outdated
@bedevere-bot

bedevere-bot commented Nov 5, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland

erlend-aasland commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Nov 5, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka approved these changes Nov 5, 2020
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland

erlend-aasland commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing, @serhiy-storchaka!

@serhiy-storchaka

serhiy-storchaka commented Nov 5, 2020

Copy link
Copy Markdown
Member

And it could be good idea to add tests for filename to all existing deprecation tests.

@erlend-aasland

erlend-aasland commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

And it could be good idea to add tests for filename to all existing deprecation tests.

I agree. I can open an issue for it.

@erlend-aasland

erlend-aasland commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

And it could be good idea to add tests for filename to all existing deprecation tests.

There's a lot:

bash$ grep -r "DeprecationWarning" Lib/test | grep -v " as " | wc -l (master)cpython.git
519

vstinner
vstinner reviewed Nov 5, 2020
View reviewed changes
Comment threadLib/sqlite3/deprecated.py Outdated
Comment threadMisc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst Outdated
Comment threadDoc/whatsnew/3.10.rst Outdated
Erlend Egeberg Aaslandand others added 2 commits November 5, 2020 20:11
Erlend Egeberg Aasland@vstinner
Address review: Improve NEWS text
3cd247f
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend E. Aasland
Address review: improve "What's new"
b106c9e
@erlend-aasland

erlend-aasland commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

PTAL, @vstinner

erlend-aasland
erlend-aasland commented Nov 5, 2020
View reviewed changes
Comment threadLib/sqlite3/__init__.py Outdated
@erlend-aasland

erlend-aasland commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

FYI, Ubuntu CI hangs again:
test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

@vstinner

vstinner commented Nov 6, 2020

Copy link
Copy Markdown
Member

test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

It is a know issue https://bugs.python.org/issue42142

You can ignore it. When it happens, I simply re-run the job until it pass.

vstinner
vstinner reviewed Nov 6, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it's way better! More comments.

Comment threadMisc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst Outdated
Comment threadLib/sqlite3/__init__.py Outdated
Erlend E. Aaslandand others added 2 commits November 6, 2020 20:08
Erlend E. Aasland
Address review comment: Improve NEWS entry
2507fd0
Use the same text as the What's New entry.
Erlend E. Aasland@vstinner
Address review comment: Add bpo reference to __init__.py
fe7c65e
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland

erlend-aasland commented Nov 6, 2020

Copy link
Copy Markdown
ContributorAuthor

Please take another look, @vstinner.

vstinner
vstinner approved these changes Nov 12, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka: Do you want to double check this PR?

@erlend-aasland

erlend-aasland commented Nov 17, 2020

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka Will you merge this after double checking, or will that be up to another core dev to decide?

@serhiy-storchaka
serhiy-storchaka merged commit a1f401a into python:masterNov 17, 2020
@erlend-aasland
erlend-aasland deleted the bpo-42264 branch November 17, 2020 19:55
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-42264: Deprecate sqlite3.OptimizedUnicode (pythonGH-23163)
36a56d2
This was referenced May 9, 2022
Closed
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 9, 2022
@erlend-aasland
pythongh-92547: Remove deprecated sqlite3 features
8312697
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:
- sqlite3.OptimizedUnicode (pythongh-23163)
- sqlite3.enable_shared_cache (pythongh-24008)
Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request May 16, 2022
@erlend-aasland@JelleZijlstra
gh-92547: Remove deprecated sqlite3 features (#92548)
00f22e8
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:
- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
+1 more reviewer
@hafizulsaat92hafizulsaat92hafizulsaat92 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@bedevere-bot@serhiy-storchaka@vstinner@hafizulsaat92@the-knights-who-say-ni