Skip to content

gh-92547: Remove deprecated sqlite3 features - #92548

Merged
erlend-aasland merged 5 commits into
mainfrom
sqlite-remove-deprecated-features
May 16, 2022
Merged

gh-92547: Remove deprecated sqlite3 features#92548
erlend-aasland merged 5 commits into
mainfrom
sqlite-remove-deprecated-features

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 9, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com

Closes#92547

@erlend-aasland
gh-92547: Remove deprecated sqlite3 features
8312697
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:
- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)
Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
JelleZijlstra
JelleZijlstra approved these changes May 10, 2022
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

@erlend-aasland

erlend-aasland commented May 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

FTR, nltk/nltk#3000 was just merged.

@JelleZijlstra

JelleZijlstra commented May 16, 2022

Copy link
Copy Markdown
Member

Feel free to merge!

@erlend-aasland
erlend-aasland merged commit 00f22e8 into mainMay 16, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-remove-deprecated-features branch May 16, 2022 17:52
@erlend-aasland

erlend-aasland commented May 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks for helping, Jelle and Victor!

@erlend-aaslanderlend-aasland mentioned this pull request May 16, 2022
Closed
@vstinner

vstinner commented May 17, 2022

Copy link
Copy Markdown
Member

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

@erlend-aasland

erlend-aasland commented May 17, 2022

Copy link
Copy Markdown
ContributorAuthor

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

Yes, I'll amend What's New. Thanks for the heads-up!

@erlend-aasland

erlend-aasland commented Jun 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Would you mind to copy these information in What's New in Python 3.12?

Something like this? #93872

@vstinner

vstinner commented Jun 16, 2022

Copy link
Copy Markdown
Member

Something like this? #93872

That's very valuable, thanks.

donbarbos added a commit to donbarbos/typeshed that referenced this pull request Mar 29, 2026
@donbarbos
[sqlite3] Deprecate undocumented enable_shared_cache
7d91fcb
Source: python/cpython#92548
@donbarbosdonbarbos mentioned this pull request Mar 29, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3: remove features deprecated in 3.10

4 participants

@erlend-aasland@JelleZijlstra@vstinner@bedevere-bot