Skip to content

bpo-43181: Make PyObject_TypeCheck a static inline function - #24533

Merged
vstinner merged 5 commits into
python:masterfrom
erlend-aasland:make-pyobject-typecheck-inline
Feb 15, 2021
Merged

bpo-43181: Make PyObject_TypeCheck a static inline function#24533
vstinner merged 5 commits into
python:masterfrom
erlend-aasland:make-pyobject-typecheck-inline

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Feb 15, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Feb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@vstinner Would you mind reviewing this?

(cc. @gpshead )

vstinner
vstinner reviewed Feb 15, 2021
View reviewed changes
Comment threadInclude/object.h Outdated
Comment threadMisc/NEWS.d/next/Core and Builtins/2021-02-11-11-37-14.bpo-43181.ydv33S.rst Outdated
Comment threadInclude/object.h Outdated
Comment threadInclude/object.h Outdated
Erlend Egeberg Aaslandand others added 3 commits February 15, 2021 12:25
Erlend Egeberg Aasland@vstinner
Improve NEWS text
36f742a
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend E. Aasland
Address review
b19bf6a
- Improve naming: Use 'type' iso. 'tp'
- Remove PyAPI_FUNC def
- Remove unneeded parens
Erlend E. Aasland
Fix ReST formatting
ad499ae
@erlend-aasland

erlend-aasland commented Feb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

CI is done; PTAL @vstinner

@vstinner
vstinner merged commit 4bb2a1e into python:masterFeb 15, 2021
@erlend-aasland
erlend-aasland deleted the make-pyobject-typecheck-inline branch February 15, 2021 16:22
@erlend-aaslanderlend-aasland mentioned this pull request Feb 16, 2021
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 17, 2021
Erlend E. Aasland
MovepythonGH-24533,pythonGH-24535, andpythonGH-24548NEWS entries …
c794f9c
…to "C API" section
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-43181: Convert PyObject_TypeCheck to static inline function (pyth…
50002fc
…onGH-24533)
@numberZeronumberZeromannequin mentioned this pull request Jun 20, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@vstinner@the-knights-who-say-ni@bedevere-bot